[FEAT] 프로젝트 카드 동적 쿼리 조회 로직 구현, 커서 기반 페이지네이션 적용 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 248f26e. ♻️ This comment has been updated with latest results. |
happyjamy
approved these changes
Feb 18, 2024
| return cursorId != null ? project.id.eq(cursorId) : null; | ||
| } | ||
|
|
||
| private Slice<Project> checkLastPage(List<Project> projects, Pageable pageable) { |
There was a problem hiding this comment.
저 같으면 여기서 Slice<Project> 생성까지 안할 것 같아요
There was a problem hiding this comment.
명시적인 이름을 갖는 메서드를 따로 두는 게 좋지 않을까 생각했는데 불필요한 것 같아서 메서드 하나로 처리하도록 수정했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 개발 사항
이슈 번호
특이 사항 🫶