[FEAT] 프로젝트 종료시 채팅방 종료 스케쥴링 추가 #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results46 tests 46 ✅ 1s ⏱️ Results for commit 363410c. |
JIN-076
reviewed
Mar 29, 2024
| @@ -82,4 +83,10 @@ private void sendMatchFailNotification() { | |||
| ); | |||
| } | |||
|
|
|||
| private void closeChatRoom() { | |||
There was a problem hiding this comment.
만약 스케줄러가 실패했을 때의 처리는 어떻게 하나요? 다음날 스케줄러가 돌때까지 채팅방이 열려있게 되나요!
There was a problem hiding this comment.
스케쥴링 실패 이후에 대해서는 생각을 안해봤네요! 한번 같이 고민해봐야할 것 같습니다 ㅠㅠ
JIN-076
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 개발 사항
이슈 번호
특이 사항 🫶