Refact/#207 chatroom domain #214
Conversation
[MERGE] dev λ₯Ό main μ λ³ν©
develop to main (HOTFIX)
[MERGE] mainμ develop λ°μ
Alpha Update
tidavid1
added
π Refactor
tidavid1
requested review from
JIN-076 and
happyjamy
and removed request for
JIN-076
Test Results0 testsβββ0 β
ββ0s β±οΈ Results for commit 7b3b8f4. β»οΈ This comment has been updated with latest results. |
| @@ -17,7 +16,7 @@ public class CursorPaginationInfoReq { | |||
| private final int pageSize; | |||
|
|
|||
| @Nullable | |||
| private final Sort.Direction sortOrder; | |||
| private final Direction sortOrder; | |||
There was a problem hiding this comment.
Sort.Directionκ³Ό Directionμ μ°¨μ΄κ° λκ°μ? (κΆκΈ)
There was a problem hiding this comment.
λμΌν ν΄λμ€μμ!
| return chatRoomRepository.findAllChatRoomByUserId(userId); | ||
| public CursorPaginationResult<ChatRoomPublicRes> findAllChatRoomByUserId(Long userId, | ||
| CursorPaginationInfoReq pageable) { | ||
| log.info("findAllChatRoomByUserId - userId: {}", userId); |
There was a problem hiding this comment.
ππ» μ΄μ λ‘κ·Έ μ°λκ±° μΆκ°ν΄μΌνλλ° μ΄ λΆλΆλ 컨벀μ κ³ λ―Όν΄λ³΄λ©΄ μ’μ λ― ν©λλ€~
| } | ||
|
|
||
| @Transactional | ||
| public void leaveChatroom(Long userId, String chatRoomId) { | ||
| var user = findUserById(userId); | ||
| var chatRoom = findChatRoomById(chatRoomId); | ||
|
|
||
| chatRoom.leaveUser(user); |
There was a problem hiding this comment.
μ±ν λλ©μΈ 리ν©ν΄μ μ¬λ €μ£Όλ©΄ μ±ν λ°© λκ°κΈ° λ‘μ§ μμ νκ² λ€κ³ μκΈ°νμλλ° μ΄λ―Έ ꡬνμ΄ λ€ λμ΄μκ΅°μ,,,! μμΌλ‘λ 미리 μ§κ² λ€κ³ λ§ν΄μ£Όλ©΄ μ’μ κ² κ°μμπ
| ChatRoom.builder().project(project).creator(creator).sender(sender).build()); | ||
| chatRepository.createCollection(chatRoom.getId()); | ||
| return ChatRoomCreateRes.from(chatRoom); | ||
| public void createChatRoom(Project project, User creator, User sender) { |
There was a problem hiding this comment.
μμ μ½λμμλ μ ν¨μ±μ κ²μ¬νλ λ‘μ§μ΄ μμλλ° μλ‘ λ°λ λ‘μ§μλ μλ κ² κ°μμ νΉμ μΌλΆλ¬ μ κ±°ν μ΄μ κ° μμκΉμ?
There was a problem hiding this comment.
μ΄λ―Έ 맀μΉμλΉμ€μμ μ ν¨μ± κ²μ¬λ₯Ό μ§νν΄μ μΆκ°μ μΌλ‘ μ§νν νμκ° μλ€κ³ νλ¨νμ΅λλ€!
π κ°λ° μ¬ν
ChatRoom리νν λ§μ μ§ννμ΅λλ€.ChatRoomμΌλ‘ λ³κ²½λμμ΅λλ€.μ΄μ λ²νΈ