use threading to run jobmanager loop #614
Open
+196
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soxofaan
reviewed
Sep 12, 2024
| @@ -252,6 +255,43 @@ def _normalize_df(self, df: pd.DataFrame) -> pd.DataFrame: | |||
|
|
|||
| return df | |||
|
|
|||
| def start_job_thread(self,start_job: Callable[[], BatchJob], | |||
There was a problem hiding this comment.
Using "thread" in naming and docs might be confusing and setting wrong expectations as asyncio is not about threading but coroutines
There was a problem hiding this comment.
it's now converted to use an actual 'Thread' object, so the confusion is gone?
There was a problem hiding this comment.
@soxofaan if this is fine now, we can merge and continue with the other PR's
jdries
changed the title
soxofaan
reviewed
Sep 19, 2024
soxofaan
reviewed
Sep 19, 2024
tests/extra/test_job_management.py
Outdated
| year = int(row["year"]) | ||
| return BatchJob(job_id=f"job-{year}", connection=connection) | ||
|
|
||
| df = manager._normalize_df(df) |
There was a problem hiding this comment.
shouldn't this normalize_df be handled automatically in the manager?
There was a problem hiding this comment.
we lack a good mechanism to initialize a job db correctly, we'll have to come up with something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to allow running the jobmanager cycle in a separate thread, allowing for a more clean option to interrupt it.