Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark mode support for alert dialog on Android 15 #1250

Closed
wants to merge 2 commits into from

Conversation

amrhossamdev
Copy link
Member

Fixes #1247.

Summary

Alert dialogs were not functioning correctly on Android 15 when invoked from any Fragment, as noted in ticket #1247. The issue did not affect alert dialogs called from activities, where they continued to work as expected.

Fix

A custom alert dialog implementation was added across the application. The solution has been tested on Android 7, 11, 12, 13, 14, and 15, using Google Pixel 8 Pro and Ximote Note 8 Pro devices.

Screenshot

Before:
After:

TODO

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with gradlew connectedObaGoogleDebugAndroidTest to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)

@advait-zx
Copy link

hey @amrhossamdev can i work on it?

@amrhossamdev
Copy link
Member Author

**advait-zx ** commented

Hi advait it's already a fix.

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be sure to rebase this against main so you don't have conflicting, identical commits in your PR and be sure to remove the stray K character!

onebusaway-android/build.gradle Show resolved Hide resolved
@amrhossamdev
Copy link
Member Author

I will close this and i will rebase from the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Out of Area warning text is missing
3 participants