add validation for duration

OmniFlix · Sep 13, 2022 · 733e505 · 733e505
1 parent e623cf0
commit 733e505
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/x/marketplace/types/msgs.go b/x/marketplace/types/msgs.go
@@ -229,6 +229,9 @@ func (msg MsgCreateAuction) ValidateBasic() error {
 	if err = ValidatePrice(msg.StartPrice); err != nil {
 		return err
 	}
+	if err = ValidateDuration(*msg.Duration); err != nil {
+		return err
+	}
 	if !msg.IncrementPercentage.IsPositive() || !msg.IncrementPercentage.LTE(sdk.NewDec(1)) {
 		return sdkerrors.Wrapf(ErrInvalidPercentage, "invalid percentage value (%s)", msg.IncrementPercentage.String())
 	}

diff --git a/x/marketplace/types/validation.go b/x/marketplace/types/validation.go
@@ -1,7 +1,6 @@
 package types
 
 import (
-	"fmt"
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
 	"strings"
@@ -44,10 +43,13 @@ func ValidatePrice(price sdk.Coin) error {
 	return nil
 }
 
-func ValidateTimeStamp(t interface{}) error {
-	_, ok := t.(time.Duration)
+func ValidateDuration(t interface{}) error {
+	duration, ok := t.(time.Duration)
 	if !ok {
-		return fmt.Errorf("invalid value for start time: %T", t)
+		return sdkerrors.Wrapf(ErrInvalidDuration, "invalid value for duration: %T", t)
+	}
+	if duration.Nanoseconds() <= 0 {
+		return sdkerrors.Wrapf(ErrInvalidDuration, "invalid duration %s, only accepts positive value", duration.String())
 	}
 	return nil
 }