[Not for merge] Optim effects optional #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
work around a bug with dune 3.9 on windows
Recent versions of node define `navigator` but not `navigator.userAgent`.
In fast mode, we don't track function arguments, so we should consider them as escaping.
* Misc: switch to ocaml.5.01 * Misc: update CI * Tests: make tests more robust wrt module offset * Tests: enable testing of ppx_deriving for OCaml ge 5.1 only * Tests: make toplevel tests more robust wrt newlines * Tests: make toplevel tests more robust wrt newlines
This fixes the trampoline call in caml_call_cps_exact_mono_N functions.
as it was introduced in OCaml 4.13.
Reverting c3e9bb6 was a mistake for these files.
`caml_callback` is needed when double translation is disabled, and the toplevel must be translated in CPS.
Instead of copying the whole test directory, the same functionality can probably be achieved using Dune profiles.
OlivierNicole
force-pushed
the
optim_effects_optional
branch
from
72e5013
to
7beefaf
Compare
|
Properly submitted a while ago as ocsigen#1461 where the journey continues. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is solely to use Github’s diff UI.