Migrate Qaterial from Qt5 to Qt6 #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ Make QtGraphicalEffect part of library
ssakone
changed the title
Merged
OlivierLDff
added a commit
that referenced
this pull request
Aug 20, 2024
This PR introduce some breaking change: - Stop support for Qt5 - Not sure WASM works - Not sure static works (ios) (I guess Qt is doing that by itself now) - Installing only work for shared library. This is what you generally want anyway. On the new features: - It works with Qt6 using qt5compat module for effect - It uses qt6 macros (that is why installation doesn't work anymore) and drop my QtGeneratorCmake dependency - flake dev shell, to quickly get a working dev env Thanks to #111 and #135 for the prep work --------- Co-authored-by: Beautify Robot <[email protected]>
|
Superseded by #157. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should work with all Qt 6 version.