-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A non-MSALJS error on MS 365 sign in #7995
Comments
Thank you for contacting us! Any issue or feedback from you is quite important to us. We will do our best to fully respond to your issue as soon as possible. Sometimes additional investigations may be needed, we will usually get back to you within 2 days by adding comments to this issue. Please stay tuned. |
This is happening to me too - no changes in my project or account... |
Sorry for your inconvenience, you can try to delete files in I have created an issue in MSAL to take a look. AzureAD/microsoft-authentication-library-for-js#5779 |
Also to me and other 2 colleagues. We don't have any folder ~/.fx/account |
I have no account folder under ~/.fx/... |
@johndavidsimmons When you click M365 sign in, there is a button to create a test account. You can try to create a test account (https://developer.microsoft.com/en-us/microsoft-365/dev-program). In this way, you can have full control of M365 permission control. |
I've already created a testing tenant. When I attempt to sign in and use it i get the message about needing a work or school account |
After signing in this page(https://developer.microsoft.com/en-us/microsoft-365/dev-program), Can you see this part. The onmicrosoft account should be your test account. If you cannot see this, you need to set up a new subscription. (prepare M365 environment: https://learn.microsoft.com/en-us/microsoftteams/platform/concepts/build-and-test/prepare-your-o365-tenant) |
Thanks for looking into it, I don't have a account folder either. I've tried deleting the Cache folder from |
That's exactly my same problem: it is happening immediately on click of the sign in button, preventing the opening of the browser, giving the following error: @azure/[email protected] : Error - A non-MSALJS error was thrown while attempting to get the cloud instance discovery metadata. Probably there's a certificate to renew on the service which is responsible for the discovery metadata. |
|
Still happening to me... click sign in and immediate get @azure/[email protected] : Error - A non-MSALJS error was thrown while attempting to get the cloud instance discovery metadata. |
@Ric-Lavers Did you do anything like clearing cache, different deafult browser, etc? |
@johndavidsimmons unfortunately it is now back same as before. |
Still a issue in VS code, looks like there are some ongoing MSAL issues shared by @cheenamalhotra. Hopefully, there will be fix for the extension soon. |
Thanks for the information. Can you tell me which teamsfx cli version do you use? And do you use any proxy in your VS Code or OS? Or does your company have a proxy? Can you open this url If you can use teamsfx cli to login, you can use VsCode to debug Teams app because teamsfx cli and teamsfx VS Code extension share the same M365 account. |
Ref: AzureAD/microsoft-authentication-library-for-js#4879 (comment) This worked for our VSCode-MSSQL extension, and we've also got confirmation from impacted customers with the recent "certificate has expired" error (microsoft/azuredatastudio#22227 (comment)).. might as well give it a try! |
Thanks for the help, we will investigate this. |
teamsfx cli version : 1.2.4 After signing in with the CLI, it still throws the same error when trying in VS code. Also, when i try to sign into azure on VS code i get the below messaging (yes i am connected to the internet 😋 ) @xiaolang124 happy to provide more details, or a screenshare. |
@Ric-Lavers I'm also having the same issue, I downloaded the extension within my VsCode Instance 2 weeks ago, and had zero issue with my sign-in. Pulled it open today, and I'm getting the exact same information notification around "you appear to be offline. Please check your network connection." Teams Toolkit: v4.99.2023021100 |
@Ric-Lavers I have created a VSIX file with the latest @azure/msal-node (1.16.0). This file is only for troubleshooting purposes and not an official release. We will publish an official version to fix this issue once we identify the root cause. Please download this VSIX file and install it in your VS Code and test it. Then let us know the results. Thank you. local-test.vsix |
@Ric-Lavers I have found a possible solution that might fix your problem. If you can try, please let us know the results. |
@xiaolang124 Great i can now sign in to MS365 after unchecking Http: System Certificates , however i'm now getting a new error when trying to sign into Azure. This is happening on both v9.9.9-local.647 & v4.2.4 |
Thanks for the information. Can you sign in Azure by using command palette (Azure: Sign in). If possible, could you successfully provision or deploy? |
@xiaolang124
|
Are you using 'MSAL' here? If so, you may want to consider switching to 'ADAL' and giving it a try. |
@xiaolang124 |
Can you give this test vsix a try and tell us the results? And what Azure account extension version do you use? If you can see your token log in your output channel, you can tell us the token structure like {"token":"*","expiresOnTimestamp":1679028706000} by hiding secret value. |
Azure account extension version: v0.11.3 The Test vsix is successfully logging into Azure, local preview and deploying 🎉 The output structure from the vsix matches your example, but there's no output just the error popup from v4.2.4 |
Thanks for the information, we will investigate this. |
There has to be just some certificate to clear or refresh. I just installed vs code and the teams toolkit extension on a new computer and used a browser that has never signed into a microsoft account before and everything works perfectly... |
Checked with the VS Code team and they said that there might be an expired root certificate in your system.
Originally posted by @chrmarti in microsoft/vscode#177175 (comment) |
When signing in to the microsoft 365 account to enable side-loading, instead of opening a login page in browser its immediately logging the below in the output tab, the login process then hangs until timeout.
[Error] - [Wed, 08 Mar 2023 16:34:51 GMT] : @azure/[email protected] : Error - A non-MSALJS error was thrown while attempting to get the cloud instance discovery metadata. Error: Error Error Description: Error: certificate has expired
To Reproduce
Steps to reproduce the behavior:
Expected behavior
should open browser with sign in page
Additional context
I've tried restarting vs code, un-installing then re-installing the extensions Toolkit and Azure Account (along with its dependent extensions )
The text was updated successfully, but these errors were encountered: