feat: update sample config schema #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tecton
requested review from
HuihuiWu-Microsoft,
wenytang-ms,
MSFT-yiz,
eriolchan,
huimiu,
hund030,
JerryYangKai,
kimizhu,
swatDong,
kuojianlu,
adashen,
1yefuwang1 and
yukun-dong
as code owners
.config/samples-config-v3.json
Outdated
| "time": "5min to run", | ||
| "configuration": "Ready for debug", | ||
| "gifPath": "images/helloWorld-tab-with-backend.gif", | ||
| "minimumToolkitVersion": "5.0.0", |
There was a problem hiding this comment.
Should here be maximumToolkitVersion? For example, TTK released v5.0.0 but some of the samples haven't been migrated, then the max version supported is v4.x.x.
There was a problem hiding this comment.
Yes, minimumToolkitVersion can be removed here. maximumToolkitVersion is optional and only will be added when the sample is not working for new TTK version.
HuihuiWu-Microsoft
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
baseUrl.onboardDate,types,gifPath,minimumToolkitVersion.urltodownloadUrl.