Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noahdarveau/Rollup changes for treeshaking #2513

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

noahdarveau-MSFT
Copy link
Contributor

@noahdarveau-MSFT noahdarveau-MSFT commented Sep 16, 2024

For more information about how to contribute to this repo, visit this page.

Description

Summarize the changes, including the goals and reasons for this change. Be sure to call out any technical or behavior changes that reviewers should be aware of.

If this Pull Request should close/resolve any issues when merged, use the special syntax for that here.

Main changes in the PR:

  1. Added Rollup to the repository which will be used to build a treeshakable version of Teams-JS once the treeshaking code changes go in.
  2. Changed the pkg.json file to have the main field point to the minified cdn bundle and added the module field to point to the esm bundle.
  3. Added a basic tree shaking test app that was used to verify tree shaking is working in teams-js. Note that there are no automated tests to check if tree shaking is working.

Validation

Validation performed:

  1. <Step 1>
  2. <Step 2>

Unit Tests added:

Unit tests are required for all changes. If no unit tests were added as part of this change, please explain why they aren't necessary.

<Yes/No>

End-to-end tests added:

<Yes/No>

Additional Requirements

Change file added:

Ensure the change file meets the formatting requirements.

<Yes/No>

Related PRs:

Remove this section if n/a

Next/remaining steps:

List the next or remaining steps in implementing the overall feature in subsequent PRs (or is the feature 100% complete after this?).

Remove this section if n/a

  • Item 1
  • Item 2

Screenshots:

Remove this section if n/a

Before After
< image1 > < image2 >

@noahdarveau-MSFT noahdarveau-MSFT changed the title noahdarveau/treeshaking noahdarveau/Rollup changes fo treeshaking Sep 23, 2024
@noahdarveau-MSFT noahdarveau-MSFT changed the title noahdarveau/Rollup changes fo treeshaking noahdarveau/Rollup changes for treeshaking Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant