-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added externalAppCardActionsForCEA APIs #2507
Conversation
This pull request contains changes to the runtime.ts file. If you, as the author of this PR, have made changes to the Runtime interface please review RUNTIME.md to determine if a new runtime version is required. Please reply to this comment stating what changes, if any, were made to the runtime object and whether a new runtime version was required. |
1f83796
to
ee5ab0d
Compare
0fedde4
to
98ef498
Compare
d755182
to
26f2731
Compare
26f2731
to
1199c21
Compare
change/@microsoft-teams-js-75e3c524-ba26-4b6a-b01b-9a1f0e315d91.json
Outdated
Show resolved
Hide resolved
apps/teams-test-app/src/components/privateApis/ExternalAppCardActionsForCEAAPIs.tsx
Outdated
Show resolved
Hide resolved
apps/teams-test-app/src/components/privateApis/ExternalAppCardActionsForCEAAPIs.tsx
Outdated
Show resolved
Hide resolved
apps/teams-test-app/src/components/privateApis/ExternalAppCardActionsForCEAAPIs.tsx
Outdated
Show resolved
Hide resolved
packages/teams-js/test/private/externalAppCardActionsForCEA.spec.ts
Outdated
Show resolved
Hide resolved
2c71f5c
to
268f8fc
Compare
Thanks @AE-MS for taking the time to review my PR and for leaving so many great suggestions. Updated the code to address them all. |
packages/teams-js/test/private/externalAppCardActionsForCEA.spec.ts
Outdated
Show resolved
Hide resolved
Thanks for considering my input! With the updated code, I left just a few more comments/questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asked for some updates to documentation/comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2de3058
to
d6a0b87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For more information about how to contribute to this repo, visit this page.
Description
Main changes in the PR:
Unit Tests added:
End-to-end tests added:
Additional Requirements
Change file added:
Related PRs:
Next/remaining steps:
Add UI tests