Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added externalAppCardActionsForCEA APIs #2507

Merged
merged 11 commits into from
Sep 25, 2024
Merged

Added externalAppCardActionsForCEA APIs #2507

merged 11 commits into from
Sep 25, 2024

Conversation

MengyiGong
Copy link
Contributor

@MengyiGong MengyiGong commented Sep 11, 2024

For more information about how to contribute to this repo, visit this page.

Description

Added externalAppCardActionsForCEA APIs

If this Pull Request should close/resolve any issues when merged, use the special syntax for that here.

Main changes in the PR:

  1. Added externalAppCardActionsForCEA APIs
  2. Moved the common models used for both externalAppCardActionsForCEC and externalAppCardActions APIs into interface files.

Unit Tests added:

Unit tests are required for all changes. If no unit tests were added as part of this change, please explain why they aren't necessary.

End-to-end tests added:

Additional Requirements

Change file added:

Ensure the change file meets the formatting requirements.

Related PRs:

Remove this section if n/a

Next/remaining steps:

Add UI tests

Copy link
Contributor

This pull request contains changes to the runtime.ts file. If you, as the author of this PR, have made changes to the Runtime interface please review RUNTIME.md to determine if a new runtime version is required. Please reply to this comment stating what changes, if any, were made to the runtime object and whether a new runtime version was required.

@MengyiGong MengyiGong force-pushed the maggieg/add_card_cec branch 3 times, most recently from d755182 to 26f2731 Compare September 19, 2024 20:17
@MengyiGong MengyiGong changed the title [WIP] CEC Card API changes Add externalAppCardActionsForCEA APIs Sep 19, 2024
@MengyiGong MengyiGong changed the title Add externalAppCardActionsForCEA APIs Added externalAppCardActionsForCEA APIs Sep 19, 2024
@MengyiGong MengyiGong marked this pull request as ready for review September 19, 2024 20:23
@MengyiGong MengyiGong requested a review from a team as a code owner September 19, 2024 20:23
@MengyiGong
Copy link
Contributor Author

Thanks @AE-MS for taking the time to review my PR and for leaving so many great suggestions. Updated the code to address them all.

@AE-MS
Copy link
Contributor

AE-MS commented Sep 20, 2024

Thanks for considering my input! With the updated code, I left just a few more comments/questions.

Copy link
Contributor

@TrevorJoelHarris TrevorJoelHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked for some updates to documentation/comments

AE-MS
AE-MS previously approved these changes Sep 23, 2024
Copy link
Contributor

@AE-MS AE-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@AE-MS AE-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@MengyiGong MengyiGong merged commit 57ea793 into main Sep 25, 2024
29 checks passed
@MengyiGong MengyiGong deleted the maggieg/add_card_cec branch September 25, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants