Skip to content

Commit

Permalink
Added messageId on the stage open API to popout channel meeting tab c…
Browse files Browse the repository at this point in the history
…ontent. (#2484)

* Adding messageId in the stage open param

* Added change file logs

* Updated the change log comment

* Updated the change file comments

* Update change/@microsoft-teams-js-a5218507-221a-43fb-9564-a80174a8f210.json

---------

Co-authored-by: dechowdhury <[email protected]_msteamsmdb>
Co-authored-by: jadahiya-MSFT <[email protected]>
Co-authored-by: Trevor Harris <[email protected]>
  • Loading branch information
4 people authored Aug 27, 2024
1 parent 04789a4 commit cf2e722
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 1 deletion.
3 changes: 2 additions & 1 deletion apps/teams-test-app/e2e-test-data/stageView.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
"title": "title",
"websiteUrl": "websiteUrl",
"entityId": "entityId",
"openMode": "modal"
"openMode": "modal",
"messageId": "messageId"
},
"expectedAlertValue": "stageView.open called with ##JSON_INPUT_VALUE##",
"expectedTestAppValue": "opened",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "Added optional field `messageId` to `stageView.open`. Passing `messageId` to `stageView.open` allows opening the stageView in a channel meeting",
"packageName": "@microsoft/teams-js",
"email": "[email protected]_msteamsmdb",
"dependentChangeType": "patch"
}
5 changes: 5 additions & 0 deletions packages/teams-js/src/public/stageView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ export namespace stageView {
*/
threadId: string;

/**
* The messageId identifies a particular channel meeting within the channel as specified by the threadId above. This should be used only when trying to open the stage view for a channel meeting. It will be a no-op for other scenarios
*/
messageId?: string;

/**
* The title to give the stage view.
*/
Expand Down
1 change: 1 addition & 0 deletions packages/teams-js/test/public/stageView.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ describe('stageView', () => {
websiteUrl: 'websiteUrl',
entityId: 'entityId',
openMode: stageView.StageViewOpenMode.modal,
messageId: 'messageId'
};

describe('isSupported', () => {
Expand Down

0 comments on commit cf2e722

Please sign in to comment.