[NIT-2554][Config Change] Test manual batch-poster fallback for DAS #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The batch-poster wasn't using the DAS because the max retention period wasn't being set correctly.
This test checks whether the batch-poster manual fallback for DAS works correctly. Here are the steps of the test: * Setup a L2 chain using a DAS * Sends a batch using the DAS * Shutdown the DAS * Fail to send a batch because the fallback is disabled * Enable the fallback * Verify the batch was sent with the fallback
cla-bot
bot
added
the
s
gligneul
changed the title
diegoximenes
previously approved these changes
Sep 12, 2024
eljobe
requested changes
Sep 12, 2024
| ParentChainNodeURL: "none", | ||
| RequestTimeout: 5 * time.Second, | ||
| } | ||
| config := das.DefaultDataAvailabilityConfig |
There was a problem hiding this comment.
I know this is something where it would be nice if we could develop an internally-accepted style guide, but:
I really find the inline declaration of the struct more readable. The structure of the data easier to visualize.
There was a problem hiding this comment.
In this case, I'm not using a composite literal because I want to initialize all fields based on the default config. The default config had changed, and the DAS tests were not using the correct config because of that.
Rename --node.batch-poster.disable-dap-fallback-store-data-on-chain to --node.batch-poster.enable-dap-fallback-store-data-on-chain
gligneul
changed the title
…-poster-das-fallback' into gligneul/test-batch-poster-das-fallback
amsanghi
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test checks whether the batch-poster manual fallback for DAS works
correctly. Here are the steps of the test:
Close NIT-2557
Config Change
Rename
node.batch-poster.disable-dap-fallback-store-data-on-chaintonode.batch-poster.enable-dap-fallback-store-data-on-chain