Get rid of the hardcoded list of chains in config_arbitrum.go (geth) instead use arbitrum_chain_info.json (nitro) #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead use arbitrum_chain_info.json (nitro)
cla-bot
bot
added
the
s
cmd/chaininfo/chain_defaults.go
Outdated
| @@ -0,0 +1,141 @@ | |||
| // Copyright 2021-2022, Offchain Labs, Inc. | |||
There was a problem hiding this comment.
nitpick: Update date to 2024
| } | ||
| } | ||
|
|
||
| func CopyArbitrumChainParams(arbChainParams params.ArbitrumChainParams) params.ArbitrumChainParams { |
There was a problem hiding this comment.
nitpick: don't need to export those copy funcs.
There was a problem hiding this comment.
I thought these functions would be handy in other places of the codebases, dont you think so?
There was a problem hiding this comment.
Maybe 🤔.
I usually only export it if already exists one place outside of the package trying to use it, but it is OK exporting it.
diegoximenes
reviewed
Nov 7, 2024
Comment on lines
+103
to
+117
| func ArbitrumOneParams() params.ArbitrumChainParams { | ||
| return fetchArbitrumChainParams("arb1") | ||
| } | ||
| func ArbitrumNovaParams() params.ArbitrumChainParams { | ||
| return fetchArbitrumChainParams("nova") | ||
| } | ||
| func ArbitrumRollupGoerliTestnetParams() params.ArbitrumChainParams { | ||
| return fetchArbitrumChainParams("goerli-rollup") | ||
| } | ||
| func ArbitrumDevTestParams() params.ArbitrumChainParams { | ||
| return fetchArbitrumChainParams("arb-dev-test") | ||
| } | ||
| func ArbitrumDevTestDASParams() params.ArbitrumChainParams { | ||
| return fetchArbitrumChainParams("anytrust-dev-test") | ||
| } |
There was a problem hiding this comment.
I didn't find any place in which those functions are used, why we need them?
| } | ||
| } | ||
|
|
||
| func CopyArbitrumChainParams(arbChainParams params.ArbitrumChainParams) params.ArbitrumChainParams { |
There was a problem hiding this comment.
Maybe 🤔.
I usually only export it if already exists one place outside of the package trying to use it, but it is OK exporting it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes nitro to only use
arbitrum_chain_info.jsonto create defaultChainConfigs andArbitrumChainParamsand removes these hardcoded defaults from the geth side.Pulls geth PR- OffchainLabs/go-ethereum#357
Resolves NIT-2732