Enable dataposter for validator contract wallet #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
…tro into dataposter-for-validator-contract-wallet
amsanghi
previously approved these changes
Aug 10, 2023
| @@ -68,8 +68,8 @@ func (s *Storage) Put(_ context.Context, index uint64, prev, new *storage.Queued | |||
| s.queue = append(s.queue, new) | |||
| } else if index >= s.firstNonce { | |||
| queueIdx := int(index - s.firstNonce) | |||
| if queueIdx > len(s.queue) { | |||
| return fmt.Errorf("attempted to set out-of-bounds index %v in queue starting at %v of length %v", index, s.firstNonce, len(s.queue)) | |||
There was a problem hiding this comment.
any particular reason for suppressing this error? earlier out-of-bound issues will be masked as notEqual error now.
Also this might hide one off errors in s.queue. Please confirm with Lee once.
There was a problem hiding this comment.
Reverted this and addressed the part that was requiring out-of-bound indexes so that it's no longer needed.
…r-for-validator-contract-wallet
…ter-disable-option
Add option to dataposter to not store the state
…:OffchainLabs/nitro into dataposter-for-validator-contract-wallet
… timeoutchallenge transactions in validator
PlasmaPower
reviewed
Aug 15, 2023
staker/validator_wallet.go
Outdated
| Data: data, | ||
| GasFeeCap: gasFeeCap, | ||
| GasTipCap: gasTipCap, | ||
| GasPrice: gp, |
There was a problem hiding this comment.
Specifying GasPrice is redundant if you already specify GasFeeCap and GasTipCap
staker/validator_wallet.go
Outdated
| @@ -326,6 +403,7 @@ func (v *ContractValidatorWallet) TestTransactions(ctx context.Context, txs []*t | |||
| Value: totalAmount, | |||
| Data: realData, | |||
| } | |||
| log.Error("anodar testTransactions pendingcallcontract", "msg", msg) | |||
There was a problem hiding this comment.
I think this was left in by mistake
There was a problem hiding this comment.
Thanks for the catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.