Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetL1RewardRate and GetL1RewardRecipient methods to ArbGasInfo #1775

Merged
merged 7 commits into from
Aug 4, 2023

Conversation

ganeshvanahalli
Copy link
Contributor

This PR creates two new functions to get L1 pricer reward rate and reward recipient in ArbOS version 11

PR for changes to the ArbGasInfo interface file inside solidity contract -> OffchainLabs/nitro-contracts#44

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jul 20, 2023
@ganeshvanahalli ganeshvanahalli marked this pull request as ready for review July 25, 2023 15:54
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #1775 (a8777a1) into master (bdd5e0d) will increase coverage by 24.92%.
The diff coverage is 20.00%.

@@             Coverage Diff             @@
##           master    #1775       +/-   ##
===========================================
+ Coverage   31.79%   56.72%   +24.92%     
===========================================
  Files         215      222        +7     
  Lines       32182    33572     +1390     
===========================================
+ Hits        10233    19043     +8810     
+ Misses      20727    12177     -8550     
- Partials     1222     2352     +1130     

PlasmaPower
PlasmaPower previously approved these changes Aug 3, 2023
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 64c03d8 into master Aug 4, 2023
8 checks passed
@PlasmaPower PlasmaPower deleted the l1Pricer-reward-methods branch August 4, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants