-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve chain owners list in ArbOS version 11 upgrade #1768
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1768 +/- ##
==========================================
+ Coverage 56.74% 56.81% +0.07%
==========================================
Files 222 222
Lines 33559 33605 +46
==========================================
+ Hits 19042 19094 +52
+ Misses 12174 12151 -23
- Partials 2343 2360 +17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some small comments but this approach looks great :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, please check for more security issues |
This PR creates a new function to resolve incorrect mapping between ChainOwners map and list.
PR for changes to the ArbOwner interface file inside solidity contract -> OffchainLabs/nitro-contracts#46