Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve chain owners list in ArbOS version 11 upgrade #1768

Merged
merged 17 commits into from
Aug 7, 2023

Conversation

ganeshvanahalli
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli commented Jul 18, 2023

This PR creates a new function to resolve incorrect mapping between ChainOwners map and list.

PR for changes to the ArbOwner interface file inside solidity contract -> OffchainLabs/nitro-contracts#46

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #1768 (f26735b) into master (39c8d78) will increase coverage by 0.07%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #1768      +/-   ##
==========================================
+ Coverage   56.74%   56.81%   +0.07%     
==========================================
  Files         222      222              
  Lines       33559    33605      +46     
==========================================
+ Hits        19042    19094      +52     
+ Misses      12174    12151      -23     
- Partials     2343     2360      +17     

Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some small comments but this approach looks great :)

arbos/addressSet/addressSet.go Outdated Show resolved Hide resolved
arbos/addressSet/addressSet.go Outdated Show resolved Hide resolved
arbos/addressSet/addressSet_test.go Show resolved Hide resolved
arbos/arbosState/arbosstate.go Outdated Show resolved Hide resolved
arbos/addressSet/addressSet.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 3fb0dd5 into master Aug 7, 2023
8 checks passed
@ganeshvanahalli ganeshvanahalli deleted the resolve-chain-owners branch August 8, 2023 14:53
@amirkhan7javi
Copy link

Thanks, please check for more security issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants