Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t treat validator wallet messages as errors #1721

Merged
merged 9 commits into from
Jul 12, 2023

Conversation

anodar
Copy link
Contributor

@anodar anodar commented Jun 26, 2023

No description provided.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jun 26, 2023
@anodar anodar changed the title Don't return an error when creating new key Don’t treat validator wallet messages as errors Jun 26, 2023
@anodar anodar marked this pull request as ready for review June 26, 2023 16:00
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/nitro/nitro.go Show resolved Hide resolved
@anodar anodar requested a review from PlasmaPower July 11, 2023 21:20
@anodar anodar requested a review from PlasmaPower July 11, 2023 21:46
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit a08fc67 into master Jul 12, 2023
7 checks passed
@PlasmaPower PlasmaPower deleted the validator-messages branch July 12, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants