Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous L3 timing fixes #1717

Merged
merged 4 commits into from
Jun 24, 2023
Merged

Miscellaneous L3 timing fixes #1717

merged 4 commits into from
Jun 24, 2023

Conversation

PlasmaPower
Copy link
Collaborator

@PlasmaPower PlasmaPower commented Jun 23, 2023

  • Fix various places where L1 block numbers were called parent chain block numbers, and vice versa
  • Fix minAssertionPeriod not being respected because L1 and parent chain block numbers were confused in l1_validator.go
  • Fix header_reader.go assuming that chains with non-zero difficulty didn't have finality (Arbitrum chains have a difficulty of 1 and have finality)
  • Fix parentChainBlockNumber and l1BlockNumber function in delayed.go
  • Run the delayed sequencer at startup, in case the parent chain isn't producing new blocks but there are new delayed messages to sequence. This also matches the behavior of the sequencer coordinator sequencing delayed messages when acquiring the lockout.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jun 23, 2023
amsanghi
amsanghi previously approved these changes Jun 23, 2023
@PlasmaPower PlasmaPower merged commit 47f76bb into master Jun 24, 2023
7 checks passed
@PlasmaPower PlasmaPower deleted the l3-timing-fixes branch June 24, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants