Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maintenance lock to sequencers #1709

Merged
merged 10 commits into from
Jun 21, 2023
Merged

Add maintenance lock to sequencers #1709

merged 10 commits into from
Jun 21, 2023

Conversation

anodar
Copy link
Contributor

@anodar anodar commented Jun 19, 2023

Also

  • switch to using table driven tests [0]
  • use proper abbreviation for receiver (mc for MaintenanceRunner instead of just c) [1]
  • refactor and simplify maybeRunMaintenance function

[0] https://google.github.io/styleguide/go/decisions#table-driven-tests
[1] https://google.github.io/styleguide/go/decisions#receiver-names

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jun 19, 2023
PlasmaPower
PlasmaPower requested changes Jun 19, 2023
View reviewed changes
arbnode/maintenance.go Outdated Show resolved Hide resolved
arbnode/maintenance.go Outdated Show resolved Hide resolved
arbnode/maintenance.go Show resolved Hide resolved
@anodar anodar requested a review from PlasmaPower June 19, 2023 19:52
PlasmaPower
PlasmaPower reviewed Jun 21, 2023
View reviewed changes
arbnode/maintenance.go Outdated Show resolved Hide resolved
@anodar anodar requested a review from PlasmaPower June 21, 2023 15:24
PlasmaPower
PlasmaPower approved these changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 7c6240e into master Jun 21, 2023
7 checks passed
@PlasmaPower PlasmaPower deleted the seq-maintenance-lock branch June 21, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlasmaPower PlasmaPower PlasmaPower approved these changes

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anodar @PlasmaPower