Parse the initial data cost out of the init message #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
PlasmaPower
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1704 +/- ##
===========================================
- Coverage 56.11% 29.87% -26.24%
===========================================
Files 217 210 -7
Lines 32581 31263 -1318
===========================================
- Hits 18283 9341 -8942
- Misses 12103 20899 +8796
+ Partials 2195 1023 -1172 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in OffchainLabs/nitro-contracts#27
The "initial data cost" is the basefee if the parent chain is an L1, or the basefee + the L1 basefee estimate if the parent chain is an Arbitrum chain.
I also refactored the init message code a bit to pull the fields into a
ParsedInitMessagestruct now that we have a few of them