Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go ABI fixes #1430

Closed
wants to merge 16 commits into from
Closed

Go ABI fixes #1430

wants to merge 16 commits into from

Conversation

rachel-bousfield
Copy link
Contributor

@rachel-bousfield rachel-bousfield commented Jan 10, 2023

Fixes NIT-1260
This PR fixes mistaken assumptions regarding the go abi, including how the compiler treats contiguous arguments

Additionally, this PR

  • introduces the wavm feature of arbutil
  • fixes the Makefile to now correctly build wasm libraries

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jan 10, 2023
@rachel-bousfield rachel-bousfield marked this pull request as ready for review January 11, 2023 04:44
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #1430 (79cc5b0) into master (ac0a2de) will decrease coverage by 1.42%.
The diff coverage is 66.66%.

❗ Current head 79cc5b0 differs from pull request most recent head 984c942. Consider uploading reports for the commit 984c942 to get more accurate results

@@            Coverage Diff             @@
##           master    #1430      +/-   ##
==========================================
- Coverage   53.68%   52.27%   -1.42%     
==========================================
  Files         209      260      +51     
  Lines       29274    34119    +4845     
  Branches        0      555     +555     
==========================================
+ Hits        15717    17837    +2120     
- Misses      11207    14218    +3011     
+ Partials     2350     2064     -286     

Copy link

@rachel-bousfield
Copy link
Contributor Author

Closing since this no longer applies in Stylus go-wasi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants