-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker layers caching in CI #76
Conversation
8ec259f
to
658d286
Compare
This looks good but I'm trying to understand it. Why does docker compose not cache the layers and we have to explicitly set a cache dir and use buildx? |
Here are some references related to docker layer caching not being natively supported in GitHub actions: We need to explicitly set a cache dir so |
658d286
to
8916287
Compare
Requesting review again after resolving git conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves NIT-2643
Fix docker layers caching in CI.
It doesn't improve CI running time by much though, something around 20% better.
You can check it working by re-running the CI workflows of this PR, or creating a new PR that doesn't modify Dockerfiles based on the branch of this PR, and check cache being hit.