Support for non-18 decimals in custom fee token #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pushed a nodejs v18 commit to |
tsahee
previously approved these changes
Jul 8, 2024
scripts/ethcommands.ts
Outdated
| @@ -77,14 +82,42 @@ async function bridgeNativeToken(argv: any, parentChainUrl: string, chainUrl: st | |||
| const sleep = (ms: number) => new Promise(r => setTimeout(r, ms)); | |||
| while (true) { | |||
| const balance = await bridger.getBalance() | |||
| if (balance.gte(ethers.utils.parseEther(argv.amount))) { | |||
| if (balance.gte(0)) { | |||
There was a problem hiding this comment.
.gte(depositAmount)?
gte(0) will not work for 2nd transfer, gte(depositAmount) will at least work if 2nd transfer is larger than previous balance which seems reasonable.
there are probably better ways
There was a problem hiding this comment.
In case when fee token has non-18 decimals, depositAmount is not equal to the amount minted on L2 (we do inflation/deflation to match 18-decimals denomination for native currency). I've improved this check to properly wait for expected amount to be minted on L2 3af86a0
gzeoneth
approved these changes
Jul 9, 2024
Sneh1999
pushed a commit
to Sneh1999/nitro-testnode
that referenced
this pull request
Jul 19, 2024
Set simple is false when running espresso
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--l3-fee-token-decimalsflag to support custom number of decimals in Orbit's fee token.Ie. this will spin up an Orbit chain with 6 decimals fee token: