Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: verification improvements #225

Merged
merged 8 commits into from
Aug 15, 2024
Merged

chore: verification improvements #225

merged 8 commits into from
Aug 15, 2024

Conversation

gzeoneth
Copy link
Member

@gzeoneth gzeoneth commented Aug 6, 2024 •
edited
Loading

  • Upgrade from hardhat-etherscan to hardhat-verify
  • Use ArbSepolia Arbiscan API
  • Force verification even when previously verified
  • Improve verification error handling
  • Disambiguous Bridge contract with BridgeUnproxied mock contract

@gzeoneth gzeoneth requested a review from gvladika August 6, 2024 12:14
@cla-bot cla-bot bot added the s label Aug 6, 2024
gvladika
gvladika approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@gvladika gvladika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gzeoneth gzeoneth merged commit 4cbf68f into develop Aug 15, 2024
12 checks passed
@gzeoneth gzeoneth deleted the verify-improve branch August 15, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvladika gvladika gvladika approved these changes

Assignees
No one assigned
Labels
s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gzeoneth @gvladika