Integrate CaptureArbitrumStorageGet/Set into the prestate tracer #352
+77
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et-prestatetracer
ganeshvanahalli
requested review from
diegoximenes,
amsanghi,
magicxyyz and
gligneul
diegoximenes
requested changes
Aug 27, 2024
diegoximenes
previously approved these changes
Sep 5, 2024
…]et initialization for prestateTracer
diegoximenes
requested changes
Nov 7, 2024
|
|
||
| ArbitrumStorage map[common.Hash]common.Hash `json:"arbitrumStorage,omitempty"` | ||
|
|
||
| empty bool |
There was a problem hiding this comment.
Original geth has this empty property.
To minimize conflicts when updating this fork with changes introduced in the original geth, how about letting this empty property right after the Storage property?
Comment on lines
+217
to
+220
| postAccount := &account{ | ||
| Storage: make(map[common.Hash]common.Hash), | ||
| ArbitrumStorage: make(map[common.Hash]common.Hash), | ||
| } |
There was a problem hiding this comment.
To later minimize git conflicts when updating this fork with changes from the original geth:
Suggested change
| postAccount := &account{ | |
| Storage: make(map[common.Hash]common.Hash), | |
| ArbitrumStorage: make(map[common.Hash]common.Hash), | |
| } | |
| postAccount := &account{Storage: make(map[common.Hash]common.Hash)} | |
| postAccount.ArbitrumStorage = make(map[common.Hash]common.Hash) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled by OffchainLabs/nitro#2602
Part of NIT-2733