Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rollingupdate data from updatestrategy for nitro #77

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Remove rollingupdate data from updatestrategy for nitro #77

merged 6 commits into from
Aug 29, 2024

Conversation

a-thomas-22
Copy link
Collaborator

nitro chart is not able to be configured to use updateStrategy.type: OnDelete
a. the base values.yaml sets updateStrategy.rollingUpdate.partition: 0, this causes deploys to error because OnDelete cannot support the rollingUpdatekey
b. we are currently using pulumi to deploy the helm charts, and pulumi has an issue piping null values to charts. otherwise i could use this to nullify the rollingUpdate config.
c. updateStrategy.rollingUpdate.partition already defaults to 0 for statefulsets, so a fix here could be not explicitly setting rollingUpdate in values.yaml

@a-thomas-22
Remove rollingupdate data from updatestrategy
bd0ea05 
nitro chart is not able to be configured to use updateStrategy.type: OnDelete
 a. the base values.yaml sets updateStrategy.rollingUpdate.partition: 0, this causes deploys to error because OnDelete cannot support the rollingUpdatekey
 b. we are currently using pulumi to deploy the helm charts, and pulumi has an issue piping null values to charts.  otherwise i could use this to nullify the rollingUpdate config.
 c. updateStrategy.rollingUpdate.partition already defaults to 0 for statefulsets, so a fix here could be not explicitly setting rollingUpdate in values.yaml
@a-thomas-22 a-thomas-22 requested a review from a team as a code owner August 29, 2024 03:06
@a-thomas-22 a-thomas-22 enabled auto-merge (squash) August 29, 2024 13:37
@a-thomas-22 a-thomas-22 merged commit de819b3 into main Aug 29, 2024
4 checks passed
@a-thomas-22 a-thomas-22 deleted the at/nitro-remove-updatestrategy-defaults branch August 29, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-vest chris-vest chris-vest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-thomas-22 @chris-vest