Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run cctp tests on approval #1895

Merged
merged 33 commits into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
a84b47a
test: Run cctp tests on approval
chrstph-dvx Sep 12, 2024
139647b
Remove false
chrstph-dvx Sep 12, 2024
c74849f
Add trigger on comment
chrstph-dvx Sep 12, 2024
8a41e8b
Add PR submit trigger
chrstph-dvx Sep 12, 2024
3c6db03
Add run-name
chrstph-dvx Sep 12, 2024
6c52ed5
Update the same check
chrstph-dvx Sep 13, 2024
7460b6e
Only rerun e2e
chrstph-dvx Sep 13, 2024
8f9cfad
Always update Test E2E
chrstph-dvx Sep 13, 2024
21a648b
Update dismiss
chrstph-dvx Sep 13, 2024
9ce3b0f
Update USDC amount
chrstph-dvx Sep 13, 2024
33052cd
Extract CCTP workflow
chrstph-dvx Sep 13, 2024
26bcc1f
Merge branch 'master' into fs-802-run-cctp-tests-on-approval
chrstph-dvx Sep 13, 2024
8ff1f23
Change extension
chrstph-dvx Sep 16, 2024
bb0a2d6
Disable fail-on-cache
chrstph-dvx Sep 16, 2024
eb2ac99
Wait for build step
chrstph-dvx Sep 16, 2024
4f502b9
Extract CCTP workflow
chrstph-dvx Sep 16, 2024
aaa8156
Merge branch 'master' into fs-802-run-cctp-tests-on-approval
chrstph-dvx Sep 16, 2024
0a8a4ac
Only cancel previous CCTP tests
chrstph-dvx Sep 16, 2024
c1a92f2
Add 'with L3' for orbit tests
chrstph-dvx Sep 16, 2024
486eac3
Properly set orbit flag for testnode
chrstph-dvx Sep 16, 2024
d430e8c
Fix condition
chrstph-dvx Sep 16, 2024
8664c79
Extract check-files and check-is-hotfix
chrstph-dvx Sep 17, 2024
3fa0216
typo
chrstph-dvx Sep 17, 2024
a05dec7
Merge branch 'master' into fs-802-run-cctp-tests-on-approval
chrstph-dvx Sep 17, 2024
7cad700
Merge branch 'master' into fs-802-run-cctp-tests-on-approval
chrstph-dvx Sep 17, 2024
33b9b8b
Address comments
chrstph-dvx Sep 18, 2024
9ad84da
Merge branch 'master' into fs-802-run-cctp-tests-on-approval
chrstph-dvx Sep 18, 2024
367195f
Add condition
chrstph-dvx Sep 18, 2024
0430145
Address comments
chrstph-dvx Sep 18, 2024
3884a9f
Remove IS_HOTFIX
chrstph-dvx Sep 18, 2024
e3de30c
Merge branch 'master' into fs-802-run-cctp-tests-on-approval
chrstph-dvx Sep 19, 2024
3cf1660
Allow to run tests on /run-cctp-tests comments
chrstph-dvx Sep 19, 2024
5a94c98
Merge branch 'master' into fs-802-run-cctp-tests-on-approval
fionnachan Sep 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions .github/actions/check-is-hotfix/action.yml

This file was deleted.

15 changes: 1 addition & 14 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,6 @@ env:
IS_HOTFIX: ${{ contains(github.event.pull_request.title, 'hotfix') }}

jobs:
check-is-hotfix:
name: Check if PR is hotfix
runs-on: ubuntu-latest
outputs:
is_hotfix: ${{ steps.check-is-hotfix.outputs.is_hotfix }}
env:
IS_HOTFIX: ${{ contains(github.event.pull_request.title, 'hotfix') }}
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/check-is-hotfix
id: check-is-hotfix
fionnachan marked this conversation as resolved.
Show resolved Hide resolved

check-files:
name: Check files
runs-on: ubuntu-latest
Expand Down Expand Up @@ -119,8 +107,7 @@ jobs:

e2e-tests:
name: "E2E Tests"
needs: [build, check-is-hotfix, check-files]
if: needs.check-is-hotfix.outputs.is_hotfix == 'false' && needs.check-files.outputs.run_tests == 'true'
fionnachan marked this conversation as resolved.
Show resolved Hide resolved
needs: [build, check-files]
uses: ./.github/workflows/e2e-tests.yml
with:
test_type: 'regular'
Expand Down
22 changes: 5 additions & 17 deletions .github/workflows/run-cctp-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ on:
- submitted
push:
branches: ["master"]
workflow_dispatch:
merge_group:

# https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency
Expand All @@ -25,18 +24,6 @@ env:
IS_HOTFIX: ${{ contains(github.event.pull_request.title, 'hotfix') }}

jobs:
check-is-hotfix:
name: Check if PR is hotfix
runs-on: ubuntu-latest
outputs:
is_hotfix: ${{ steps.check-is-hotfix.outputs.is_hotfix }}
env:
IS_HOTFIX: ${{ contains(github.event.pull_request.title, 'hotfix') }}
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/check-is-hotfix
id: check-is-hotfix

check-files:
name: Check files
runs-on: ubuntu-latest
Expand All @@ -50,8 +37,10 @@ jobs:
build:
name: "Build"
runs-on: ubuntu-latest
needs: [check-files, check-is-hotfix]
if: needs.check-files.outputs.run_tests == 'true' && needs.check-is-hotfix.outputs.is_hotfix == 'false'
needs: [check-files]
if: |
(needs.check-files.outputs.run_tests == 'true' && ${{ !contains(github.event.pull_request.title, 'hotfix') }}) ||
fionnachan marked this conversation as resolved.
Show resolved Hide resolved
(contains(github.event.comment.html_url, '/pull/') && contains(github.event.comment.body, '/test'))
fionnachan marked this conversation as resolved.
Show resolved Hide resolved
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -72,9 +61,8 @@ jobs:

cctp-e2e-tests:
name: "CCTP E2E Tests"
needs: [build, check-is-hotfix, check-files]
needs: [build, check-files]
# Only run CCTP tests when the PR was just approved
if: needs.check-is-hotfix.outputs.is_hotfix == 'false' && needs.check-files.outputs.run_tests == 'true' && github.event_name == 'pull_request_review' && github.event.review.state == 'approved'
uses: ./.github/workflows/e2e-tests.yml
with:
test_type: 'cctp'
Expand Down
Loading