fix: set correct max amount from query params #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fionnachan
reviewed
Aug 16, 2024
Comment on lines
92
to
94
| if (maxAmount <= 0) { | ||
| return undefined | ||
| } |
There was a problem hiding this comment.
the input should still be set to the max amount available to show insufficient for gas error
otherwise clicking the max button would do nothing even though user has balance
…en-bridge into fix-max-amount
fionnachan
approved these changes
Aug 16, 2024
chrstph-dvx
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if query param
amount=max, we always set the amount to max without accounting for gas. This happens because the initialmaxAmountis undefined. Refactored it so that we wait for proper max estimation before setting the new amount.