-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: run e2e for custom fee token chains #1811
Draft
brtkx
wants to merge
35
commits into
master
Choose a base branch
from
l3-e2e-custom-fee-token
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
83b2b4b
init
brtkx 1dd83cd
Merge branch 'master' of github.com:OffchainLabs/arbitrum-token-bridg…
brtkx 0aaa3e2
more changes
brtkx 0313da6
fix build
brtkx 545ddf5
fix
brtkx cbc158d
try
brtkx 96f6c0c
revert
brtkx 4a29486
fixes
brtkx d4a2199
run redeem test
brtkx 8fd3742
Merge branch 'master' of github.com:OffchainLabs/arbitrum-token-bridg…
brtkx 3a64e1b
fix and cleanup
brtkx ded123b
Merge branch 'master' of github.com:OffchainLabs/arbitrum-token-bridg…
brtkx 3bd8df8
fix and cleanup
brtkx 98c4cb9
remove testing mock
brtkx cc288ed
fixes after merge
brtkx b736a5e
fixes
brtkx c6b9b36
Merge branch 'master' into l3-e2e
brtkx 6165988
nit
brtkx cb59c7b
Merge branch 'master' of github.com:OffchainLabs/arbitrum-token-bridg…
brtkx 97f50a4
merge
brtkx fd31688
Merge branch 'master' of github.com:OffchainLabs/arbitrum-token-bridg…
brtkx d2f9238
update
brtkx 6cbd689
Merge branch 'master' of github.com:OffchainLabs/arbitrum-token-bridg…
brtkx 571d343
update
brtkx af2d42b
revert
brtkx 28a0003
Merge branch 'master' of github.com:OffchainLabs/arbitrum-token-bridg…
brtkx 00e7bec
update readme
brtkx c5866bb
init
brtkx 20921b3
Merge branch 'master' of github.com:OffchainLabs/arbitrum-token-bridg…
brtkx c660d04
fix
brtkx 9b985b5
fix
brtkx 8fb2c0e
fix
brtkx 4d2bdaa
fix
brtkx c5562a3
fix
brtkx 6e4908b
fix arg
brtkx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -160,16 +160,19 @@ jobs: | |
|
||
# based on https://github.com/Synthetixio/synpress/blob/dev/.github/workflows/e2e_cypress-action.yml | ||
test-e2e: | ||
name: "Test E2E${{ matrix.orbit-test == '1' && ' with L3' || '' }} - ${{ matrix.tests.name }}" | ||
name: "Test E2E${{ matrix.custom-fee-token == '1' && ' with L3 (non-ETH)' || matrix.orbit-test == '1' && ' with L3 (ETH)' || '' }} - ${{ matrix.tests.name }}" | ||
runs-on: ubuntu-latest | ||
needs: [build, check-files, check-is-hotfix, load-e2e-files] | ||
if: needs.check-files.outputs.run_tests == 'true' && needs.check-is-hotfix.outputs.is_hotfix == 'false' | ||
strategy: | ||
fail-fast: false # If one test fails, let the other tests run | ||
matrix: | ||
tests: | ||
${{ fromJson(needs.load-e2e-files.outputs.matrix) }} | ||
tests: ${{ fromJson(needs.load-e2e-files.outputs.matrix) }} | ||
orbit-test: ['0', '1'] | ||
custom-fee-token: ['0', '1'] | ||
exclude: | ||
- orbit-test: '0' | ||
custom-fee-token: '1' | ||
|
||
steps: | ||
- name: Free Disk Space (Ubuntu) | ||
|
@@ -219,12 +222,18 @@ jobs: | |
nitro-testnode-ref: aab133aceadec2e622f15fa438f6327e3165392d | ||
l3-node: ${{ matrix.orbit-test == '1' }} | ||
no-l3-token-bridge: ${{ matrix.orbit-test == '0' }} | ||
args: ${{ matrix.custom-fee-token == '1' && '--l3-fee-token' || '' }} | ||
|
||
- name: Run e2e tests via cypress-io/github-action | ||
uses: cypress-io/github-action@8d3918616d8ac34caa2b49afc8b408b6a872a6f5 # [email protected] | ||
with: | ||
start: yarn start | ||
command: ${{ matrix.orbit-test == '1' && 'yarn test:e2e:orbit --browser chromium' || 'yarn test:e2e --browser chromium' }} | ||
start: ${{ matrix.custom-fee-token == '1' && 'NEXT_PUBLIC_CUSTOM_FEE_TOKEN=true yarn start' || 'yarn start' }} | ||
command: >- | ||
${{ | ||
(matrix.orbit-test == '1' && matrix.custom-fee-token == '1') && 'yarn test:e2e:orbit --browser chromium' || | ||
(matrix.orbit-test == '1' && matrix.custom-fee-token == '0') && 'yarn test:e2e:orbit --browser chromium' || | ||
'yarn test:e2e --browser chromium' | ||
}} | ||
wait-on: http://127.0.0.1:3000 | ||
wait-on-timeout: 120 | ||
spec: ./packages/arb-token-bridge-ui/tests/e2e/specs/* | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -153,7 +153,14 @@ export const localL3Network: Chain = { | |
id: ChainId.L3Local, | ||
name: 'L3 Local', | ||
network: 'l3-localhost', | ||
nativeCurrency: ether, | ||
nativeCurrency: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need to add this so that the custom fee token is detected |
||
process.env.NEXT_PUBLIC_CUSTOM_FEE_TOKEN === 'true' | ||
? { | ||
name: 'testnode', | ||
symbol: 'TN', | ||
decimals: 18 | ||
} | ||
: ether, | ||
rpcUrls: { | ||
default: { | ||
http: [rpcURLs[ChainId.L3Local]!] | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to change those because the generated L3 network has different addresses with custom fee token