Fix/forex case error #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhayes21
approved these changes
Nov 2, 2023
sambles
pushed a commit
that referenced
this pull request
Nov 9, 2023
* fix case to detect the correct column when doing a currency conversion * add list option to create currency conversion object
sambles
pushed a commit
that referenced
this pull request
Nov 9, 2023
* fix case to detect the correct column when doing a currency conversion * add list option to create currency conversion object
sambles
added a commit
that referenced
this pull request
Nov 9, 2023
* Set package to version 3.0.8 * Fix/forex case error (#70) * fix case to detect the correct column when doing a currency conversion * add list option to create currency conversion object * pep8 update * Fix publish * Update changelog --------- Co-authored-by: awsbuild <[email protected]> Co-authored-by: Stephane Struzik <[email protected]>
Merged
sambles
added a commit
that referenced
this pull request
Nov 10, 2023
* Set package to version 3.1.3 * Fix/forex case error (#70) * fix case to detect the correct column when doing a currency conversion * add list option to create currency conversion object * Update model_settings_schema.json adding event set optional dependency with valid footprint ids (#69) Allow model vendors to set dependency between event set and footprint files * Feature/versioning (#66) * CI improvement, select OED branch * check if succeeding tests on push * testing success on push * added tests * added check that versioning is present in schema * compression argument not required anymore * added test of successful versioning * commented code * improved logging and checks * code quality * review: now no need for exact version to be passed * check columns OccupancyCode and ConstructionCode exist * added warning if desired version is < than supported * removed unnecessary warnings * refactored using version from packaging library * setup.py pointing to ODS_OpenExposureData with versioning info * Update setup.py to released spec 3.1.0 --------- Co-authored-by: sambles <[email protected]> * Feature/peril filter (#73) * add peril_filter function * add numba as requirement * Update changelog * Fix changelog --------- Co-authored-by: awsbuild <[email protected]> Co-authored-by: Stephane Struzik <[email protected]> Co-authored-by: fl-ndaq <[email protected]> Co-authored-by: Nicola Cerutti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix case issue in forex conversion
when case change from lowercase to the schema case the forex module didn't follow and ended up having issue when finding column to convert. In this fix we now use the correct case.