Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make string column are writable when reading from parquet #59

Merged
merged 2 commits into from
Sep 12, 2023
Merged

make string column are writable when reading from parquet #59

merged 2 commits into from
Sep 12, 2023

Conversation

sstruzik
Copy link
Contributor

make sure column are writable before modifying them when reading from parquet

@sstruzik sstruzik added the bug Something isn't working label Sep 11, 2023
@sambles sambles linked an issue Sep 12, 2023 that may be closed by this pull request
Validation crash after converting account file from csv to parquet #58
Closed
sambles
sambles approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@sambles sambles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@sambles sambles merged commit 71069fc into main Sep 12, 2023
8 checks passed
@sambles sambles deleted the fix/58_validation_from_parquet branch September 12, 2023 08:33
sambles pushed a commit that referenced this pull request Sep 12, 2023
@sstruzik @sambles
make string column are writable when reading from parquet (#59)
a86f5ba 
* make string column are writable when reading from parquet

* pep8
@awsbuild awsbuild modified the milestones: 3.1.1rc1, 3.1.1 Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sambles sambles sambles approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Oasis Dev Team Tasks
Status: Done
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.

Validation crash after converting account file from csv to parquet
3 participants
@sstruzik @sambles @awsbuild