Transform air-oed without config file #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstruzik
reviewed
Jun 27, 2024
ods_tools/main.py
Outdated
| """ | ||
| transform_command = command_parser.add_parser('transform', description=transform_description, | ||
| formatter_class=argparse.RawTextHelpFormatter) | ||
| transform_command.add_argument('--config-file', help='Path to the config file', required=True) | ||
| transform_command.add_argument('--config-file', help='Path to the config file') | ||
| transform_command.add_argument('--oed-air', help='directly transforms OED to AIR format', action='store_true') |
There was a problem hiding this comment.
I don't think those should be direct argument of the command because you will end up having to add n^2 arguments each time you have a new built-in transformation
I would add a single argument named -f --formats
that tell you which transformation to do
either -f or --config-file needs to be present to do the transformation
There was a problem hiding this comment.
Makes sense, thanks! I changed it to -f/--format.
(in the same spirit, I changed a bit the generate_config() function too, to avoid excessive hardcoding)
sstruzik
approved these changes
Jul 1, 2024
sambles
pushed a commit
that referenced
this pull request
Jul 1, 2024
* enable transformation without config file * fix reverse mappings * comments * pep * format as argument with --format * adjust logger when failing * remove oed-air arg
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transform air to oed without config file
A simple transformation from air to oed and vice versa can be run without creating a config file, but simply by command line
It is now possible to run a transformation without using a configuration file. Solves #125.
For example, the command:
ods_tools transform --format air-oed --input-file air_input.csv --output-file oed_output.csvwill produce the oed file
output.csvfrom the air fileinput.csvWe currently support
air-oedandoed-air.