Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Lerna #189

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Feature: Lerna #189

wants to merge 20 commits into from

Conversation

UlisesGascon
Copy link
Collaborator

WIP. No Merge:

Pending

  • Documentation
    • Readme root
    • Readme server-render
  • Heroku

Context

Changelog

@UlisesGascon UlisesGascon mentioned this pull request May 30, 2020
UlisesGascon and others added 2 commits May 30, 2020 14:05
Main Changes:
- Added missing `cy:verify` script
- Added sleep for 60s as workaround.
@UlisesGascon
Copy link
Collaborator Author

@ckarande and @lirantal seems like I was able to fix the CI issues with Lerna. 🎉

I will work now on the documentation and then I will work to enable tests in CI for #193 and #197.

Important

This PR seems quite big but only few files were created/edited:

  • travis.yml for CI
  • README.md soon
  • ./package.json and ./lerna.json for Lerna (dependencies and npm scripts) and Husky (git hooks and propagation)

The rest of the files were just moved to a new location apps/server-render/** and somehow relinted

Note

We will need to review Heroku official deployment (https://nodegoat.herokuapp.com/tutorial) becuase maybe this PR will break de deploy? 🤔

The "A9 Insecure Components" example requires [email protected]; that's the newest version affected by the XSS described in the tutorial
@rcowsill
Copy link
Contributor

rcowsill commented Aug 6, 2020

In feature/187 Travis uses Lerna to start the infrastructure. Lerna invokes the start-infra npm script which runs the web service in a docker container. The dockerfile builds the server-render_web image from a base of node:12-alpine.

I think that means the web service is only tested under node 12 in this branch, despite there being travis jobs for node 8, 10 and 12.

EDIT: Also it appears that the before/after hooks that reset the DB don't work in this branch. The docker-compose.yml doesn't map the mongo port out to the host. That means the database is only accessible from other services (just web in this case), and not from the cypress tests running directly on the host VM.

EDIT 2: When launched with docker-compose up the web service always connects to the mongolab DB rather than the mongo service running inside docker. This is because NODE_ENV isn't set, so development is used by default. That's why only one of the CI jobs succeeds in each run for this branch - another job already created the new user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants