Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #169

Closed
wants to merge 2 commits into from
Closed

Upgrade dependencies #169

wants to merge 2 commits into from

Conversation

jamesleynorvil
Copy link

@jamesleynorvil jamesleynorvil commented Sep 4, 2019

Context

Changelog

  • Add the latest versions in package.json
  • Submit the changes in package-lock.json
  • Change db from callback to db = client.db()
  • Add the primary depdency list to the readme.md

@lirantal
Copy link
Collaborator

lirantal commented Sep 4, 2019

We perhaps want to use some packages with specific versions pinned down because they have known vulnerabilities that we can demo with the app so I wouldn't go as far as upgrading this without taking note what's exactly being used.

@ckarande
Copy link
Member

ckarande commented Sep 4, 2019

@jamesleynorvil Welcome to the project and thanks for your contribution 👍

@lirantal It is a good idea to demo the issue related dangers of using packages with known vulnerabilities. The existing tutorial page for the A9 risk contains an example of how to exploit an insecure version of the marked package. So it makes sense to retain the older version of it as per the latest commit from @jamesleynorvil. When you have a bandwidth, can you review the tutorial page contents and suggest in case we can improve it further.

@UlisesGascon
Copy link
Collaborator

Welcome @jamesleynorvil!

Thanks @lirantal and @ckarande for your feedback on the dependencies. I agree with you too, We need to look together for vulnerabilities patched. Right now there is no automated way to test the vulnerabilities. I expect something for that soon (Migration to purpleteam suggested by @binarymist in issue #142 at #148), we can freeze this PR until then if we want to avoid the manual review.

@UlisesGascon UlisesGascon added this to the v1.5 milestone Sep 9, 2019
@UlisesGascon UlisesGascon self-assigned this Sep 9, 2019
@UlisesGascon UlisesGascon mentioned this pull request Sep 9, 2019
31 tasks
@UlisesGascon UlisesGascon changed the base branch from master to release-1.5 September 10, 2019 05:35
@UlisesGascon
Copy link
Collaborator

@jamesleynorvil I will re-integrate this change once #187 has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants