Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates per issue 1165 #1443

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Updates per issue 1165 #1443

merged 6 commits into from
Jul 3, 2024

Conversation

markgamache
Copy link
Contributor

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

🚩 If your PR is related to grammar/typo mistakes, please double-check the file for other mistakes in order to fix all the issues in the current cheat sheet.

Please make sure that for your contribution:

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see the policy.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to websites have been formatted as [TEXT](URL)
  • You verified/tested the effectiveness of your contribution (e.g., the defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

If your PR is related to an issue, please finish your PR text with the following line:

This PR covers issue #1165.

Thank you again for your contribution 😃

Copy link
Collaborator

@kwwall kwwall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to forego official approval of this since I had a major role in assisting @markgamache with this major rewrite. I will however participate in answering questions with mark as co-author.

jmanico
jmanico previously approved these changes Jul 2, 2024
Copy link
Collaborator

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a few comments

cheatsheets/Pinning_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Pinning_Cheat_Sheet.md Show resolved Hide resolved
cheatsheets/Pinning_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Pinning_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Pinning_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Pinning_Cheat_Sheet.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my comments. LGTM!

@markgamache
Copy link
Contributor Author

@mackowski This is ready for your final review. Thx!

@szh szh merged commit e024a42 into OWASP:master Jul 3, 2024
3 checks passed
@kwwall
Copy link
Collaborator

kwwall commented Jul 3, 2024

Oh happy day. Now maybe companies will revise their SAST tools to stop warning that certificate pinning is missing for Android applications. (Or in the case of CodeQL, for Java applications that are not Android apps.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants