-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First Draft for JWT Best Practices Doc #1182
Draft
chalbersma
wants to merge
5
commits into
OWASP:master
Choose a base branch
from
chalbersma:jwt_things
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+453
−58
Draft
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,3 +12,4 @@ news.xml | |
| package-lock.json | ||
| yarn.lock | ||
| venv | ||
| /.idea | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,181 +1,227 @@ | ||
| # Introduction | ||
| # Index Alphabetical | ||
|
|
||
| **64** cheat sheets available. | ||
| **86** cheat sheets available. | ||
|
|
||
| *Icons beside the cheat sheet name indicate in which language(s) code snippet(s) are provided.* | ||
|
|
||
| [A](Index.md#a) [B](Index.md#b) [C](Index.md#c) [D](Index.md#d) [E](Index.md#e) [F](Index.md#f) [H](Index.md#h) [I](Index.md#i) [J](Index.md#j) [K](Index.md#k) [L](Index.md#l) [M](Index.md#m) [N](Index.md#n) [O](Index.md#o) [P](Index.md#p) [Q](Index.md#q) [R](Index.md#r) [S](Index.md#s) [T](Index.md#t) [U](Index.md#u) [V](Index.md#v) [W](Index.md#w) [X](Index.md#x) | ||
| [A](Index.md#a) [B](Index.md#b) [C](Index.md#c) [D](Index.md#d) [E](Index.md#e) [F](Index.md#f) [G](Index.md#g) [H](Index.md#h) [I](Index.md#i) [J](Index.md#j) [K](Index.md#k) [L](Index.md#l) [M](Index.md#m) [N](Index.md#n) [O](Index.md#o) [P](Index.md#p) [Q](Index.md#q) [R](Index.md#r) [S](Index.md#s) [T](Index.md#t) [U](Index.md#u) [V](Index.md#v) [W](Index.md#w) [X](Index.md#x) | ||
|
|
||
| ## A | ||
|
|
||
| [Access Control Cheat Sheet](cheatsheets/Access_Control_Cheat_Sheet.md). | ||
| [Authorization Cheat Sheet](cheatsheets/Authorization_Cheat_Sheet.md). | ||
|
|
||
| [Attack Surface Analysis Cheat Sheet](cheatsheets/Attack_Surface_Analysis_Cheat_Sheet.md). | ||
| [AJAX Security Cheat Sheet](cheatsheets/AJAX_Security_Cheat_Sheet.md).  | ||
|
|
||
| [Authentication Cheat Sheet](cheatsheets/Authentication_Cheat_Sheet.md). | ||
|
|
||
| [AJAX Security Cheat Sheet](cheatsheets/AJAX_Security_Cheat_Sheet.md).  | ||
| [Access Control Cheat Sheet](cheatsheets/Access_Control_Cheat_Sheet.md). | ||
|
|
||
| [Abuse Case Cheat Sheet](cheatsheets/Abuse_Case_Cheat_Sheet.md). | ||
|
|
||
| [Authorization Testing Automation Cheat Sheet](cheatsheets/Authorization_Testing_Automation_Cheat_Sheet.md).   | ||
| [Authorization Testing Automation Cheat Sheet](cheatsheets/Authorization_Testing_Automation_Cheat_Sheet.md).   | ||
|
|
||
| [Authentication Cheat Sheet](cheatsheets/Authentication_Cheat_Sheet.md). | ||
|
|
||
| [Attack Surface Analysis Cheat Sheet](cheatsheets/Attack_Surface_Analysis_Cheat_Sheet.md). | ||
|
|
||
| ## B | ||
|
|
||
| [Bean Validation Cheat Sheet](cheatsheets/Bean_Validation_Cheat_Sheet.md).   | ||
| [Bean Validation Cheat Sheet](cheatsheets/Bean_Validation_Cheat_Sheet.md).   | ||
|
|
||
| ## C | ||
|
|
||
| [Cross-Site Request Forgery Prevention Cheat Sheet](cheatsheets/Cross-Site_Request_Forgery_Prevention_Cheat_Sheet.md).  | ||
|
|
||
| [Clickjacking Defense Cheat Sheet](cheatsheets/Clickjacking_Defense_Cheat_Sheet.md).   | ||
| [Cryptographic Storage Cheat Sheet](cheatsheets/Cryptographic_Storage_Cheat_Sheet.md). | ||
|
|
||
| [Cross Site Scripting Prevention Cheat Sheet](cheatsheets/Cross_Site_Scripting_Prevention_Cheat_Sheet.md).      | ||
| [Credential Stuffing Prevention Cheat Sheet](cheatsheets/Credential_Stuffing_Prevention_Cheat_Sheet.md). | ||
|
|
||
| [Choosing and Using Security Questions Cheat Sheet](cheatsheets/Choosing_and_Using_Security_Questions_Cheat_Sheet.md). | ||
|
|
||
| [Content Security Policy Cheat Sheet](cheatsheets/Content_Security_Policy_Cheat_Sheet.md).  | ||
| [C-Based Toolchain Hardening Cheat Sheet](cheatsheets/C-Based_Toolchain_Hardening_Cheat_Sheet.md).   | ||
|
|
||
| [Credential Stuffing Prevention Cheat Sheet](cheatsheets/Credential_Stuffing_Prevention_Cheat_Sheet.md). | ||
| [Cross-Site Request Forgery Prevention Cheat Sheet](cheatsheets/Cross-Site_Request_Forgery_Prevention_Cheat_Sheet.md).  | ||
|
|
||
| [Cryptographic Storage Cheat Sheet](cheatsheets/Cryptographic_Storage_Cheat_Sheet.md). | ||
| [Content Security Policy Cheat Sheet](cheatsheets/Content_Security_Policy_Cheat_Sheet.md).   | ||
|
|
||
| [Clickjacking Defense Cheat Sheet](cheatsheets/Clickjacking_Defense_Cheat_Sheet.md).   | ||
|
|
||
| [Cross Site Scripting Prevention Cheat Sheet](cheatsheets/Cross_Site_Scripting_Prevention_Cheat_Sheet.md).  | ||
|
|
||
| ## D | ||
|
|
||
| [Deserialization Cheat Sheet](cheatsheets/Deserialization_Cheat_Sheet.md).    | ||
| [DOM based XSS Prevention Cheat Sheet](cheatsheets/DOM_based_XSS_Prevention_Cheat_Sheet.md).   | ||
|
|
||
| [Docker Security Cheat Sheet](cheatsheets/Docker_Security_Cheat_Sheet.md).  | ||
| [Denial of Service Cheat Sheet](cheatsheets/Denial_of_Service_Cheat_Sheet.md). | ||
|
|
||
| [Database Security Cheat Sheet](cheatsheets/Database_Security_Cheat_Sheet.md). | ||
| [DotNet Security Cheat Sheet](cheatsheets/DotNet_Security_Cheat_Sheet.md).      | ||
|
|
||
| [DotNet Security Cheat Sheet](cheatsheets/DotNet_Security_Cheat_Sheet.md).      | ||
| [Deserialization Cheat Sheet](cheatsheets/Deserialization_Cheat_Sheet.md).    | ||
|
|
||
| [DOM based XSS Prevention Cheat Sheet](cheatsheets/DOM_based_XSS_Prevention_Cheat_Sheet.md).   | ||
| [Docker Security Cheat Sheet](cheatsheets/Docker_Security_Cheat_Sheet.md).  | ||
|
|
||
| [Denial of Service Cheat Sheet](cheatsheets/Denial_of_Service_Cheat_Sheet.md). | ||
| [Database Security Cheat Sheet](cheatsheets/Database_Security_Cheat_Sheet.md). | ||
|
|
||
| [Django REST Framework Cheat Sheet](cheatsheets/Django_REST_Framework_Cheat_Sheet.md).  | ||
|
|
||
| [DOM Clobbering Prevention Cheat Sheet](cheatsheets/DOM_Clobbering_Prevention_Cheat_Sheet.md).   | ||
|
|
||
| ## E | ||
|
|
||
| [Error Handling Cheat Sheet](cheatsheets/Error_Handling_Cheat_Sheet.md).    | ||
| [Error Handling Cheat Sheet](cheatsheets/Error_Handling_Cheat_Sheet.md).    | ||
|
|
||
| ## F | ||
|
|
||
| [Forgot Password Cheat Sheet](cheatsheets/Forgot_Password_Cheat_Sheet.md). | ||
|
|
||
| [File Upload Cheat Sheet](cheatsheets/File_Upload_Cheat_Sheet.md). | ||
|
|
||
| [Forgot Password Cheat Sheet](cheatsheets/Forgot_Password_Cheat_Sheet.md). | ||
| ## G | ||
|
|
||
| ## H | ||
| [GraphQL Cheat Sheet](cheatsheets/GraphQL_Cheat_Sheet.md).   | ||
|
|
||
| [HTML5 Security Cheat Sheet](cheatsheets/HTML5_Security_Cheat_Sheet.md).      | ||
| ## H | ||
|
|
||
| [HTTP Strict Transport Security Cheat Sheet](cheatsheets/HTTP_Strict_Transport_Security_Cheat_Sheet.md). | ||
|
|
||
| [HTTP Headers Cheat Sheet](cheatsheets/HTTP_Headers_Cheat_Sheet.md).    | ||
|
|
||
| [HTML5 Security Cheat Sheet](cheatsheets/HTML5_Security_Cheat_Sheet.md).      | ||
|
|
||
| ## I | ||
|
|
||
| [Injection Prevention Cheat Sheet](cheatsheets/Injection_Prevention_Cheat_Sheet.md).  | ||
| [Injection Prevention in Java Cheat Sheet](cheatsheets/Injection_Prevention_in_Java_Cheat_Sheet.md). | ||
|
|
||
| [Injection Prevention in Java Cheat Sheet](cheatsheets/Injection_Prevention_in_Java_Cheat_Sheet.md).   | ||
| [Injection Prevention Cheat Sheet](cheatsheets/Injection_Prevention_Cheat_Sheet.md).  | ||
|
|
||
| [Input Validation Cheat Sheet](cheatsheets/Input_Validation_Cheat_Sheet.md).  | ||
| [Input Validation Cheat Sheet](cheatsheets/Input_Validation_Cheat_Sheet.md).  | ||
|
|
||
| [Insecure Direct Object Reference Prevention Cheat Sheet](cheatsheets/Insecure_Direct_Object_Reference_Prevention_Cheat_Sheet.md).  | ||
| [Infrastructure as Code Security Cheat Sheet](cheatsheets/Infrastructure_as_Code_Security_Cheat_Sheet.md). | ||
|
|
||
| [Insecure Direct Object Reference Prevention Cheat Sheet](cheatsheets/Insecure_Direct_Object_Reference_Prevention_Cheat_Sheet.md). | ||
|
|
||
| ## J | ||
|
|
||
| [JAAS Cheat Sheet](cheatsheets/JAAS_Cheat_Sheet.md).  | ||
| [JAAS Cheat Sheet](cheatsheets/JAAS_Cheat_Sheet.md).  | ||
|
|
||
| [JWT Cheat Sheet](cheatsheets/JWT_Cheat_Sheet.md).    | ||
|
|
||
| [JSON Web Token for Java Cheat Sheet](cheatsheets/JSON_Web_Token_for_Java_Cheat_Sheet.md).     | ||
| [Java Security Cheat Sheet](cheatsheets/Java_Security_Cheat_Sheet.md).   | ||
|
|
||
| [JSON Web Token for Java Cheat Sheet](cheatsheets/JSON_Web_Token_for_Java_Cheat_Sheet.md).     | ||
|
|
||
| ## K | ||
|
|
||
| [Key Management Cheat Sheet](cheatsheets/Key_Management_Cheat_Sheet.md). | ||
|
|
||
| [Kubernetes Security Cheat Sheet](cheatsheets/Kubernetes_Security_Cheat_Sheet.md).   | ||
|
|
||
| ## L | ||
|
|
||
| [Logging Cheat Sheet](cheatsheets/Logging_Cheat_Sheet.md). | ||
| [Logging Vocabulary Cheat Sheet](cheatsheets/Logging_Vocabulary_Cheat_Sheet.md). | ||
|
|
||
| [LDAP Injection Prevention Cheat Sheet](cheatsheets/LDAP_Injection_Prevention_Cheat_Sheet.md). | ||
|
|
||
| [Logging Cheat Sheet](cheatsheets/Logging_Cheat_Sheet.md). | ||
|
|
||
| [Laravel Cheat Sheet](cheatsheets/Laravel_Cheat_Sheet.md).     | ||
|
|
||
| ## M | ||
|
|
||
| [Multifactor Authentication Cheat Sheet](cheatsheets/Multifactor_Authentication_Cheat_Sheet.md). | ||
|
|
||
| [Mass Assignment Cheat Sheet](cheatsheets/Mass_Assignment_Cheat_Sheet.md).     | ||
|
|
||
| [Microservices based Security Arch Doc Cheat Sheet](cheatsheets/Microservices_based_Security_Arch_Doc_Cheat_Sheet.md). | ||
|
|
||
| [Mass Assignment Cheat Sheet](cheatsheets/Mass_Assignment_Cheat_Sheet.md).     | ||
|
|
||
| [Microservices Security Cheat Sheet](cheatsheets/Microservices_Security_Cheat_Sheet.md). | ||
|
|
||
| ## N | ||
|
|
||
| [NodeJS Security Cheat Sheet](cheatsheets/Nodejs_Security_Cheat_Sheet.md).    | ||
| [NPM Security Cheat Sheet](cheatsheets/NPM_Security_Cheat_Sheet.md). | ||
|
|
||
| [NodeJS Docker Cheat Sheet](cheatsheets/NodeJS_Docker_Cheat_Sheet.md). | ||
|
|
||
| [Nodejs Security Cheat Sheet](cheatsheets/Nodejs_Security_Cheat_Sheet.md).   | ||
|
|
||
| [Network Segmentation Cheat Sheet](cheatsheets/Network_Segmentation_Cheat_Sheet.md). | ||
|
|
||
| ## O | ||
|
|
||
| [OS Command Injection Defense Cheat Sheet](cheatsheets/OS_Command_Injection_Defense_Cheat_Sheet.md).    | ||
| [OS Command Injection Defense Cheat Sheet](cheatsheets/OS_Command_Injection_Defense_Cheat_Sheet.md).    | ||
|
|
||
| ## P | ||
|
|
||
| [Password Storage Cheat Sheet](cheatsheets/Password_Storage_Cheat_Sheet.md). | ||
|
|
||
| [PHP Configuration Cheat Sheet](cheatsheets/PHP_Configuration_Cheat_Sheet.md). | ||
|
|
||
| [Pinning Cheat Sheet](cheatsheets/Pinning_Cheat_Sheet.md). | ||
|
|
||
| [Prototype Pollution Prevention Cheat Sheet](cheatsheets/Prototype_Pollution_Prevention_Cheat_Sheet.md).  | ||
|
|
||
| [PHP Configuration Cheat Sheet](cheatsheets/PHP_Configuration_Cheat_Sheet.md). | ||
|
|
||
| ## Q | ||
|
|
||
| [Query Parameterization Cheat Sheet](cheatsheets/Query_Parameterization_Cheat_Sheet.md).        | ||
| [Query Parameterization Cheat Sheet](cheatsheets/Query_Parameterization_Cheat_Sheet.md).        | ||
|
|
||
| ## R | ||
|
|
||
| [REST Security Cheat Sheet](cheatsheets/REST_Security_Cheat_Sheet.md). | ||
|
|
||
| [REST Assessment Cheat Sheet](cheatsheets/REST_Assessment_Cheat_Sheet.md). | ||
|
|
||
| [Ruby on Rails Cheat Sheet](cheatsheets/Ruby_on_Rails_Cheat_Sheet.md).    | ||
| [Ruby on Rails Cheat Sheet](cheatsheets/Ruby_on_Rails_Cheat_Sheet.md).    | ||
|
|
||
| [REST Security Cheat Sheet](cheatsheets/REST_Security_Cheat_Sheet.md). | ||
|
|
||
| ## S | ||
|
|
||
| [Securing Cascading Style Sheets Cheat Sheet](cheatsheets/Securing_Cascading_Style_Sheets_Cheat_Sheet.md). | ||
| [Server Side Request Forgery Prevention Cheat Sheet](cheatsheets/Server_Side_Request_Forgery_Prevention_Cheat_Sheet.md).     | ||
|
|
||
| [SQL Injection Prevention Cheat Sheet](cheatsheets/SQL_Injection_Prevention_Cheat_Sheet.md).      | ||
| [Secure Product Design Cheat Sheet](cheatsheets/Secure_Product_Design_Cheat_Sheet.md). | ||
|
|
||
| [Server Side Request Forgery Prevention Cheat Sheet](cheatsheets/Server_Side_Request_Forgery_Prevention_Cheat_Sheet.md).     | ||
| [Secure Cloud Architecture Cheat Sheet](cheatsheets/Secure_Cloud_Architecture_Cheat_Sheet.md). | ||
|
|
||
| [SAML Security Cheat Sheet](cheatsheets/SAML_Security_Cheat_Sheet.md). | ||
| [SQL Injection Prevention Cheat Sheet](cheatsheets/SQL_Injection_Prevention_Cheat_Sheet.md).      | ||
|
|
||
| [Session Management Cheat Sheet](cheatsheets/Session_Management_Cheat_Sheet.md). | ||
|
|
||
| [Secrets Management Cheat Sheet](cheatsheets/Secrets_Management_Cheat_Sheet.md). | ||
|
|
||
| [SAML Security Cheat Sheet](cheatsheets/SAML_Security_Cheat_Sheet.md). | ||
|
|
||
| [Securing Cascading Style Sheets Cheat Sheet](cheatsheets/Securing_Cascading_Style_Sheets_Cheat_Sheet.md). | ||
|
|
||
| ## T | ||
|
|
||
| [Transaction Authorization Cheat Sheet](cheatsheets/Transaction_Authorization_Cheat_Sheet.md). | ||
|
|
||
| [TLS Cipher String Cheat Sheet](cheatsheets/TLS_Cipher_String_Cheat_Sheet.md). | ||
| [Transport Layer Protection Cheat Sheet](cheatsheets/Transport_Layer_Protection_Cheat_Sheet.md).  | ||
|
|
||
| [Transport Layer Protection Cheat Sheet](cheatsheets/Transport_Layer_Protection_Cheat_Sheet.md).  | ||
| [TLS Cipher String Cheat Sheet](cheatsheets/TLS_Cipher_String_Cheat_Sheet.md). | ||
|
|
||
| [Third Party Javascript Management Cheat Sheet](cheatsheets/Third_Party_Javascript_Management_Cheat_Sheet.md).   | ||
| [Third Party Javascript Management Cheat Sheet](cheatsheets/Third_Party_Javascript_Management_Cheat_Sheet.md).   | ||
|
|
||
| [Threat Modeling Cheat Sheet](cheatsheets/Threat_Modeling_Cheat_Sheet.md). | ||
|
|
||
| ## U | ||
|
|
||
| [User Privacy Protection Cheat Sheet](cheatsheets/User_Privacy_Protection_Cheat_Sheet.md). | ||
|
|
||
| [Unvalidated Redirects and Forwards Cheat Sheet](cheatsheets/Unvalidated_Redirects_and_Forwards_Cheat_Sheet.md).     | ||
| [Unvalidated Redirects and Forwards Cheat Sheet](cheatsheets/Unvalidated_Redirects_and_Forwards_Cheat_Sheet.md).     | ||
|
|
||
| ## V | ||
|
|
||
| [Virtual Patching Cheat Sheet](cheatsheets/Virtual_Patching_Cheat_Sheet.md).  | ||
|
|
||
| [Vulnerability Disclosure Cheat Sheet](cheatsheets/Vulnerability_Disclosure_Cheat_Sheet.md). | ||
|
|
||
| [Vulnerable Dependency Management Cheat Sheet](cheatsheets/Vulnerable_Dependency_Management_Cheat_Sheet.md).  | ||
| [Virtual Patching Cheat Sheet](cheatsheets/Virtual_Patching_Cheat_Sheet.md).  | ||
|
|
||
| [Vulnerable Dependency Management Cheat Sheet](cheatsheets/Vulnerable_Dependency_Management_Cheat_Sheet.md).  | ||
|
|
||
| ## W | ||
|
|
||
| [Web Service Security Cheat Sheet](cheatsheets/Web_Service_Security_Cheat_Sheet.md). | ||
|
|
||
| ## X | ||
|
|
||
| [XML External Entity Prevention Cheat Sheet](cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.md).     | ||
| [XML Security Cheat Sheet](cheatsheets/XML_Security_Cheat_Sheet.md).    | ||
|
|
||
| [XML External Entity Prevention Cheat Sheet](cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.md).     | ||
|
|
||
| [XSS Filter Evasion Cheat Sheet](cheatsheets/XSS_Filter_Evasion_Cheat_Sheet.md).   | ||
|
|
||
| [XML Security Cheat Sheet](cheatsheets/XML_Security_Cheat_Sheet.md).    | ||
| [XS Leaks Cheat Sheet](cheatsheets/XS_Leaks_Cheat_Sheet.md).   |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # Verification | ||
|
|
||
| ## `None` Examples | ||
|
|
||
| ### Java | ||
|
|
||
| <!-- --8<-- [start:java] --> | ||
| ``` | ||
| // HMAC key - Block serialization and storage as String in JVM memory | ||
| private transient byte[] keyHMAC = ...; | ||
|
|
||
| ... | ||
|
|
||
| //Create a verification context for the token requesting | ||
| //explicitly the use of the HMAC-256 hashing algorithm | ||
| JWTVerifier verifier = JWT.require(Algorithm.HMAC256(keyHMAC)).build(); | ||
|
|
||
| //Verify the token, if the verification fail then a exception is thrown | ||
| DecodedJWT decodedToken = verifier.verify(token); | ||
| ``` | ||
| <!-- --8<-- [end:java] --> | ||
|
|
||
| ### Python:pyjwt | ||
|
|
||
| <!-- --8<-- [start:pyjwt] --> | ||
| ``` | ||
| try: | ||
| pyjwt.decode(encoded, key, algorithms=["HS256","ES256"]) | ||
| except Exception as error: | ||
| # handle exception here | ||
| raise error | ||
| else: | ||
| continue | ||
| ``` | ||
| <!-- --8<-- [end:pyjwt] --> | ||
|
|
||
| ### NodeJS:Jose | ||
|
|
||
| <!-- --8<-- [start:jose] --> | ||
| ``` | ||
| const { payload, protectedHeader } = await jose.jwtVerify(jwt, secret, { | ||
| algorithms: "HS256" | ||
| }) | ||
|
|
||
| console.log(protectedHeader) | ||
| console.log(payload) | ||
| ``` | ||
| <!-- --8<-- [end:jose] --> | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is weird to support HS256 (a MAC) and ES256 (a signature) at the same time. Either your key is a shared secret and you will support HS256 or this is a public key and you support ES256. I think ES256 is spurious here. This would be consistent with other examples.