Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r.object.thickness: update after csv class refactoring #1146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pzatelli
Copy link
Contributor

Update module after csv class refactoring.

Update module after csv class refactoring.
@neteler neteler changed the title Update r.object.thickness.py r.object.thickness: update after csv class refactoring Jul 27, 2024
petrasovaa
petrasovaa previously approved these changes Jul 30, 2024
@echoix
Copy link
Member

echoix commented Jul 30, 2024

Hmm, why is the target branch master, and so much failing checks?

Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check branch and status checks

@petrasovaa
Copy link
Contributor

Right, I just reviewed the change itself.

@echoix
Copy link
Member

echoix commented Jul 30, 2024

I'll try changing the target base branch, let's see if it messes everything up or not.

@echoix echoix changed the base branch from master to grass8 July 30, 2024 21:16
@echoix echoix changed the base branch from grass8 to master July 30, 2024 21:18
@echoix echoix dismissed petrasovaa’s stale review July 30, 2024 21:18

The base branch was changed.

@echoix
Copy link
Member

echoix commented Jul 30, 2024

Didn't work, it should be a cherry-pick, or recreated starting from the correct branch (grass8).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants