1056 foxx test script fix

[JoshuaSBrown]

#1056

Summary by Sourcery

Fix the Foxx test script to handle unset environment variables and improve script reliability by using BASH_SOURCE for script path determination.

Bug Fixes:

• Fix the script to correctly handle unset environment variables by using parameter expansion.

Enhancements:

• Improve script reliability by changing the way the script path is determined using BASH_SOURCE instead of $0.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR fixes bash script behavior by improving environment variable handling and script path resolution. The changes make the scripts more robust by properly handling unset variables and using the correct method to determine script locations.

Class diagram for updated bash script variables

classDiagram
    class TestFoxxScript {
        -e : removed
        -u : removed
        +uf : added
        SCRIPT : updated
        DATAFED_DATABASE_PASSWORD : updated
        FOXX_MAJOR_API_VERSION : updated
    }
    class DependencyInstallFunctionsScript {
        SCRIPT : updated
    }
    note for TestFoxxScript "Improved handling of unset variables and script path resolution"
    note for DependencyInstallFunctionsScript "Updated script path resolution method"

Loading

File-Level Changes

Change	Details	Files
Improved environment variable handling in bash scripts	Added -u flag to enforce checking for unset variables Modified environment variable checks to use proper bash parameter expansion with :- operator Changed script path resolution to use BASH_SOURCE instead of $0	core/database/tests/test_foxx.sh scripts/dependency_install_functions.sh

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @JoshuaSBrown - I've reviewed your changes - here's some feedback:

Overall Comments:

• The comment about removing -u is incorrect since -u is now included in the set options. Please update the comment to reflect the current behavior.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}