Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the set-keyword-status script #227

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

hakonhagland
Copy link
Collaborator

Updated the fodt-set-keyword-status script to also handle the case when keyword is specific to OPM flow:

image

when the keyword is specific to OPM flow, the text "OPM Flow" is shown in the table as shown in the screenshot above. The script can now be run like this:

$  fodt-set-ketword-status --keyword=CSKIN --color=green --opm-flow

to put the text "OPM Flow" or just omit the flag --opm-flow to remove the text "OPM Flow".

Thanks to @gdfldm for the suggestion.

@gdfldm Can you test this?

Updated the fodt-set-keyword-status script to also handle if the
keyword is specific to OPM flow or not.
@blattms blattms requested a review from lisajulia April 12, 2024 09:37
This was referenced Apr 12, 2024
@lisajulia
Copy link
Collaborator

lisajulia commented Apr 16, 2024

I tested "fodt-set-keyword-status --keyword=CSKIN --color=green --opm-flow" and received:
No such option: --color

Then:
fodt-set-keyword-status --help

Gave me:


  Change the status of a keyword in Appendix A.

Options:
  --maindir TEXT  Directory to save generated files.
  --keyword TEXT  Keyword to change status for.  [required]
  --status TEXT   New status for keyword.  [required]
  --opm-flow      Flow specific keyword
  --help          Show this message and exit.

Is there something else I need to do?

Changed name of --status option to --color to make the name agree with
the README documentation.
@hakonhagland
Copy link
Collaborator Author

@lisajulia Thanks for noticing, I have changed the option name from --status to --color so it should agree with the explanation in the README.md.

scripts/python/README.md Outdated Show resolved Hide resolved
@lisajulia lisajulia merged commit 174f981 into OPM:main Apr 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants