Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lit question #193

Merged
merged 9 commits into from
Jul 20, 2023
Merged

Add lit question #193

merged 9 commits into from
Jul 20, 2023

Conversation

wielandb
Copy link
Contributor

This PR adds a question that asks if public_transport=platforms are lit.

7h30n3
7h30n3 requested changes Jul 19, 2023
View reviewed changes
Copy link
Member

@7h30n3 7h30n3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
Please change to question type to boolean. As this is only asked for platforms we can keep it simple and only ask if lit=yes or lit=no.

@wielandb
Change question to boolean
0257fd2 
Also, reduce osm_elements it applys to.
Also, Bahnsteig -> Steig
@Robbendebiene
Copy link
Member

LGTM. Can be merged if conflicts are solved.

@wielandb
Copy link
Contributor Author

Conflicts solved. ✔️

@Robbendebiene Robbendebiene merged commit 8fb9444 into OPENER-next:master Jul 20, 2023
3 checks passed
@wielandb wielandb deleted the lit-question branch July 20, 2023 11:25
yulieth9109 pushed a commit to yulieth9109/OpenStop that referenced this pull request Aug 31, 2023
@wielandb @Robbendebiene @yulieth9109
Add lit question (OPENER-next#193)
9c31002 
Co-authored-by: Robin Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7h30n3 7h30n3 7h30n3 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wielandb @Robbendebiene @7h30n3