Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional condition for announcements #182

Closed
wants to merge 1 commit into from

Conversation

Robbendebiene
Copy link
Member

Currently we are not asking announcements for platforms that do not have a train=yes tag like: https://www.openstreetmap.org/way/220720360 We do this, because we do not want to ask this question for tram platforms. If this tag is missing tram platforms are indistinguishable from train platforms because the railway tag doesn't differentiate between them.
So asking this question simply if railway=platform is set would show this question for a lot of tram stops like: https://www.openstreetmap.org/way/217791160

As a compromise we could only ask this question for railway=platform if it is mapped as an area, because it is more likely to be a platform for trains then.

@wielandb
Copy link
Contributor

wielandb commented Jul 2, 2023

Would we still need this precaution if #187 would be merged?
Maybe this PR could then be changed to explicitly only ask the announcement question if train=yes is set.

@Robbendebiene
Copy link
Member Author

@wielandb Yes we will probably close this PR in favour of a new PR that addresses this. There are multiple conditions that could be improved based on #182

@7h30n3 7h30n3 marked this pull request as draft July 5, 2023 13:40
@7h30n3 7h30n3 deleted the announcements-condition branch April 3, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants