Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more expressions #179

Merged
merged 9 commits into from
Jun 29, 2023
Merged

Add more expressions #179

merged 9 commits into from
Jun 29, 2023

Conversation

Robbendebiene
Copy link
Member

Adds INSERT, PAD and REPLACE expressions. Mainly to allow advanced String/Number manipulation and formatting.

@Robbendebiene Robbendebiene changed the base branch from master to stop-area-discovery June 19, 2023 10:37
@Robbendebiene Robbendebiene changed the base branch from stop-area-discovery to master June 28, 2023 08:00
7h30n3
7h30n3 requested changes Jun 28, 2023
View reviewed changes
Copy link
Member

@7h30n3 7h30n3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Maybe add a little hint in the documentation for PAD to make it more obvious for users that the disired width is more or less a minimum width depending on the padding String.

@Robbendebiene Robbendebiene merged commit e0a4787 into master Jun 29, 2023
5 of 6 checks passed
@Robbendebiene Robbendebiene deleted the more_expressions branch June 29, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7h30n3 7h30n3 7h30n3 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Robbendebiene @7h30n3