Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HiresClock ticks instead of DateTime for IntervalRunner publish time calculation #2753

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

mrsuciu
Copy link
Contributor

@mrsuciu mrsuciu commented Sep 6, 2024

Use HiresClock instead of DateTime for IntervalRunner publish time calculation

Proposed changes

PubSub IntervalRunner used System clock dependent DateTime values for calculating the publish time, which may produce wrong time values and all consequences that derive from this.
This PR replaces DateTime values in the time calculation with HiresClock (Stopwatch) monotonic values.

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 54.62%. Comparing base (6dcee7e) to head (dcdfdf3).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
Libraries/Opc.Ua.PubSub/IntervalRunner.cs 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2753      +/-   ##
==========================================
- Coverage   55.12%   54.62%   -0.51%     
==========================================
  Files         349      349              
  Lines       65548    65702     +154     
  Branches    13398    13445      +47     
==========================================
- Hits        36135    35888     -247     
- Misses      25584    25921     +337     
- Partials     3829     3893      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

while (HiResClock.Ticks < nextPublishTick)
{
// Busy-wait and avoid overhead of Task.Delay for verry small wait times
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@mregen mregen added this to the Oktober Update milestone Sep 24, 2024
@mrsuciu mrsuciu merged commit 5349d9a into OPCFoundation:master Sep 25, 2024
75 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PubSub - WriterGroup publishing time is drifting
2 participants