-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comm reference fixes + Remove __del__ method and add weakref.finalizer #712
Conversation
I think this is now the output I expect at the end of testing:
More generally at the end of any script STATE0 can have:
In its current state it looks like we can get rid of the "ignore all potential sources of error if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is OK but I don't 100% understand what is going on/why this change was necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
…omms and codepath for decreffing resultant null comms
0f789b9
to
87d227e
Compare
This was intended to be just checking current status of PyOP2 but I have discovered issues with the way the
@atexit
finalizer is cleaning up comms.