TA stack protector fix #7049
Merged
TA stack protector fix #7049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etienne-lms
reviewed
Sep 23, 2024
jforissier
force-pushed
the
stack-prot-fix
branch
from
75fa14d
to
ce3b560
Compare
|
|
jforissier
force-pushed
the
stack-prot-fix
branch
from
ce3b560
to
d6afc6c
Compare
|
@maximus64 are you OK with this? Thanks. |
|
|
Add the __no_stack_protector macro as an alias for __attribute__((no_stack_protector)), which prevents the generation by the compiler of the stack protection code. Signed-off-by: Jerome Forissier <[email protected]> Acked-by: Etienne Carriere <[email protected]> Acked-by: Jens Wiklander <[email protected]> Reviewed-by: Khoa Hoang <[email protected]>
Apply the __no_stack_protector attribute to the first C function called following the TA entry point (i.e., __ta_entry(), or for the special case of ARM32, __ta_entry_c()). This is required because __stack_chk_guard is initialized in this very function, therefore stack protection cannot be assumed to be functional at this point. Fixes a TA crash on QEMUv7 with Clang 18.1.7 [1]. Link: OP-TEE#7047 [1] Signed-off-by: Jerome Forissier <[email protected]> Acked-by: Etienne Carriere <[email protected]> Acked-by: Jens Wiklander <[email protected]> Reviewed-by: Khoa Hoang <[email protected]>
jforissier
force-pushed
the
stack-prot-fix
branch
from
d6afc6c
to
e505a13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.