feat/#350 카카오로그인 구현완료 #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JinUng41
approved these changes
Aug 31, 2024
Comment on lines
+42
to
46
| if let url = URLContexts.first?.url { | ||
| if (AuthApi.isKakaoTalkLoginUrl(url)) { | ||
| _ = AuthController.handleOpenUrl(url: url) | ||
| } | ||
| } |
There was a problem hiding this comment.
개인적인 의견입니다만, 저는 뎁스를 좀 지양하는 편이라 아래와 같이 표현도 가능해 보입니다.
// guard 문 사용
guard let url = URLContexts.first?.url, AuthApi.isKakaoTalkLoginUrl(url) else {
return
}
_ = AuthController.handleOpenUrl(url: url)
// if 문 사용
if let url = URLContexts.first?.url, AuthApi.isKakaoTalkLoginUrl(url) {
_ = AuthController.handleOpenUrl(url: url)
}
Comment on lines
+25
to
26
| KakaoSDK.initSDK(appKey: kakaoAppKey, loggingEnable: true) | ||
| print("Kakao SDK initialized with app key: \(kakaoAppKey)") |
There was a problem hiding this comment.
성공했을 때는 print 디버깅은 필요없을 것 같네요.
Comment on lines
112
to
114
| if let error = error { | ||
| print("Error fetching FCM registration token: \(error)") | ||
| } else if let token = token { |
There was a problem hiding this comment.
아래와 같이 좀 더 간결하게 표현 가능합니다. (Swift 5.7부터 인걸로 알고 있어요.)
if let error {
} else if let token {
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 연결된 이슈
📄 작업 내용
👀 기타 더 이야기해볼 점
url Type에 있던 앱 키 정보를 privacy 로 이전하고 기존 키를 지웟는데 appdelegate와 scenedelegete에서 이전 앱키를 받아오는 키로 사용하고있어서 생긴 오류였습니다. 꽤나 오래 안되고 있었을텐데 테스트로그인하느라 못본 모양이네요 모쪼록 해결햇습니다.