-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] 모임 상세 화면 약속 분기 처리 #343
Conversation
- 모임 약속은 요청 파라미터 없이 - 내가 속한 약속은 요청 파라미터 필요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
꼼꼼한 pr까지 .. 수고하셨습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다! 1.8의 저주를 이겨내셨으니 더욱 강해지시겠군요.
guard let isParticipant else { | ||
return try await request(with: .fetchMeetingPromiseList(meetingID: meetingID)) | ||
} | ||
return try await request(with: .fetchParticipatedPromiseList(meetingID: meetingID, isParticipant: isParticipant)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿!
MeetingPromise(promiseID: 1,name: "꾸물 리프레시 데이",dDay: 0,time: "PM 2:00",placeName: "DMC역"), | ||
MeetingPromise(promiseID: 2,name: "꾸물 잼얘 나이트",dDay: 10,time: "PM 6:00",placeName: "홍대입구"), | ||
MeetingPromise(promiseID: 3,name: "친구 생일 파티",dDay: 5,time: "PM 7:00",placeName: "강남역"), | ||
MeetingPromise(promiseID: 4,name: "주말 산책",dDay: 3,time: "AM 10:00",placeName: "서울숲"), | ||
MeetingPromise(promiseID: 5,name: "프로젝트 미팅",dDay: 1,time: "AM 9:00",placeName: "삼성역"), | ||
MeetingPromise(promiseID: 6,name: "독서 모임",dDay: 7,time: "PM 3:00",placeName: "합정역"), | ||
MeetingPromise(promiseID: 7,name: "헬스클럽 모임",dDay: 2,time: "AM 8:00",placeName: "신촌역"), | ||
MeetingPromise(promiseID: 8,name: "영화 관람",dDay: 4,time: "PM 8:00",placeName: "잠실역"), | ||
MeetingPromise(promiseID: 9,name: "저녁 식사",dDay: 6,time: "PM 7:30",placeName: "이태원역"), | ||
MeetingPromise(promiseID: 10,name: "아침 조깅",dDay: 14,time: "AM 6:00",placeName: "한강공원"), | ||
MeetingPromise(promiseID: 11,name: "커피 브레이크",dDay: 8,time: "PM 4:00",placeName: "을지로입구"), | ||
MeetingPromise(promiseID: 12,name: "스터디 그룹",dDay: 12,time: "PM 5:00",placeName: "강남역"), | ||
MeetingPromise(promiseID: 13,name: "뮤직 페스티벌",dDay: 9,time: "PM 2:00",placeName: "난지공원"), | ||
MeetingPromise(promiseID: 14, name: "낚시 여행", dDay: 11, time: "AM 5:00", placeName: "속초항"), | ||
MeetingPromise(promiseID: 15, name: "가족 모임", dDay: 13, time: "PM 1:00", placeName: "광화문역") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 혹시 한번에 개행 없애는 방법 아시나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나중에 직접 알려드릴게요~
UIView.animate(withDuration: 0.1) { | ||
self.underlineView.frame = CGRect( | ||
x: segmentFrame.minX + labelFrame.minX, | ||
y: self.bounds.height - 2.0, | ||
width: labelFrame.width, | ||
height: 4.0 | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 ㅎㅎ...
🔗 연결된 이슈
📄 작업 내용
💻 주요 코드 설명
📌 '내가 속한 약속'과 '모든 약속' 서버에 요청하기
MeetingService.swift
📌 밑줄을 가진 세그먼트 컨트롤
UnderlineSegmentedControl.swift
📌 '내가 속한 약속'과 '모든 약속' UI 분기처리
MeetingInfoViewModel.swift
📌 셀 선택 시 화면 이동
didSelectItemAt
을 이용합니다.MeetingInfoViewController.swift
📚 참고자료
👀 기타 더 이야기해볼 점