-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] 모임 상세 화면 삭제(나가기) 기능 및 바뀐 API 명세 반영하기 #329
Conversation
- Cell을 3가지 상태로 구분 - DTO의 time과 달리 DateString과 TimeString을 구분
- RxMoya를 사용
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋은코드 잘 구경하고갑니다
RxMoya도입이 기대되네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다. 나중에 저도 Rx를 도입하게 된다면 꼭 참고해보도록 할게요.
Member( | ||
memberID: 1, | ||
name: "김진웅", | ||
profileImageURL: "https://reqres.in/img/faces/\(Int.random(in: 1...10))-image.jpg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오? 이런게 있군요
func convertToMeetingInfoPromiseModels(from promises: [MeetingPromise]) -> [MeetingInfoPromiseModel] { | ||
let inputDateFormatter = DateFormatter() | ||
inputDateFormatter.dateFormat = "yyyy-MM-dd HH:mm:ss" | ||
|
||
let outputDateFormatter = DateFormatter().then { | ||
$0.locale = Locale(identifier: "ko_KR") | ||
$0.timeZone = TimeZone(identifier: "Asia/Seoul") | ||
$0.dateFormat = "yyyy.MM.dd a h:mm" | ||
$0.amSymbol = "AM" | ||
$0.pmSymbol = "PM" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 잘 써먹도록 하겠습니다. 감사합니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 용이하게 사용하겠습니다. 혹시 셋 모두가 필요한 함수라면 공통 메서드로 사용할 수 있게 하는 건 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그것도 괜찮은 방법이네요.
뭐 예를 들어, DateFormatter의 익스텐션 메서드를 둔다던지.. 등
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!
func configure(model: MeetingInfoPromiseModel) { | ||
dDayLabel.setText("D\(model.dDayText)", style: .body05, color: model.state.dDayTextColor) | ||
nameLabel.setText(model.name, style: .body03, color: model.state.nameTextColor) | ||
dateLabel.setText(model.dateText, style: .body06, color: model.state.otherTextColor) | ||
timeLabel.setText(model.timeText, style: .body06, color: model.state.otherTextColor) | ||
placeLabel.setText(model.placeName, style: .body06, color: model.state.otherTextColor) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
func convertToMeetingInfoPromiseModels(from promises: [MeetingPromise]) -> [MeetingInfoPromiseModel] { | ||
let inputDateFormatter = DateFormatter() | ||
inputDateFormatter.dateFormat = "yyyy-MM-dd HH:mm:ss" | ||
|
||
let outputDateFormatter = DateFormatter().then { | ||
$0.locale = Locale(identifier: "ko_KR") | ||
$0.timeZone = TimeZone(identifier: "Asia/Seoul") | ||
$0.dateFormat = "yyyy.MM.dd a h:mm" | ||
$0.amSymbol = "AM" | ||
$0.pmSymbol = "PM" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 용이하게 사용하겠습니다. 혹시 셋 모두가 필요한 함수라면 공통 메서드로 사용할 수 있게 하는 건 어떨까요?
🔗 연결된 이슈
📄 작업 내용
time
변경)💻 주요 코드 설명
View 영역에서 사용될 Model, MeetingInfoPromiseModel
MeetingInfoViewModel.swift
RxMoya 사용
MeetingService.swift